Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing HTTP requests from Bucket logging methods. #769

Merged
merged 1 commit into from
Mar 30, 2015
Merged

Removing HTTP requests from Bucket logging methods. #769

merged 1 commit into from
Mar 30, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Mar 28, 2015

Relates to #728

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 28, 2015
@dhermes dhermes mentioned this pull request Mar 28, 2015
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 74cb2b0 on dhermes:logging-no-requests into 4d69bb3 on GoogleCloudPlatform:master.

@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Mar 29, 2015
tseaver
tseaver reviewed Mar 30, 2015
View reviewed changes
gcloud/storage/test_bucket.py
@@ -758,6 +758,7 @@ def test_get_logging_w_prefix(self):
resp_to_reload = before
connection = _Connection(resp_to_reload)
bucket = self._makeOne(NAME, connection)
bucket._reload_properties()

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver tseaver mentioned this pull request Mar 30, 2015
Merged
@dhermes
Copy link
Contributor Author

dhermes commented Mar 30, 2015

@tseaver based on #773 (comment) are we a go to merge this?

@dhermes dhermes mentioned this pull request Mar 30, 2015
Closed
@dhermes
Copy link
Contributor Author

dhermes commented Mar 30, 2015

@tseaver Just rebased (the public .reload() in #770 made this un-mergeable).

Are we good?

@tseaver tseaver mentioned this pull request Mar 30, 2015
Closed
@tseaver
Copy link
Contributor

tseaver commented Mar 30, 2015

LGTM: I added #778 to track the testcase cleanups.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ed87a2f on dhermes:logging-no-requests into 522987a on GoogleCloudPlatform:master.

dhermes added a commit that referenced this pull request Mar 30, 2015
@dhermes
Merge pull request #769 from dhermes/logging-no-requests
e60acb8 
Removing HTTP requests from Bucket logging methods.
@dhermes dhermes merged commit e60acb8 into googleapis:master Mar 30, 2015
@dhermes dhermes deleted the logging-no-requests branch March 30, 2015 20:31
@dhermes dhermes mentioned this pull request Apr 9, 2015
Merged
parthea pushed a commit that referenced this pull request Jul 6, 2023
@jerjou @busunkim96
Update README.md
8008731 
Addresses #769
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhermes @coveralls @tseaver @googlebot