Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding storage.api._require_connection to allow fallback behavior. #779

Merged
merged 1 commit into from
Mar 30, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Mar 30, 2015

Allows fallback in this order:

  • explicit connection
  • current batch
  • default connection
  • raise exception

Also adding Batch.current() to determine the top batch in context.

Also making storage.Batch publicly visible (reduces number of imports).

This was peeled off from #759

Allows fallback in this order:
- explicit connection
- current batch
- default connection
- raise exception

Also adding Batch.top() to determine the current batch in
context.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 30, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f429945 on dhermes:storage-add-require-connection into e60acb8 on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor

tseaver commented Mar 30, 2015

LGTM

dhermes added a commit that referenced this pull request Mar 30, 2015
Adding storage.api._require_connection to allow fallback behavior.
@dhermes dhermes merged commit 37fb0ec into googleapis:master Mar 30, 2015
@dhermes dhermes deleted the storage-add-require-connection branch March 30, 2015 21:58
parthea pushed a commit that referenced this pull request Oct 21, 2023
…-samples#779)

* Draft of first half of KMS samples

* reversed wrong change

* KMS Apiary Python samples - P1

* Few minor style issues

* Adding back in space i accidentally deleted

* Addressed all code review comments

* Renamed api directory to api-client

* Addressed more code review comments

* Formatting change

* Fix quickstart test

Change-Id: Ib79dc1345c9c40547f3fd4e9c3c9a48963a3b399

* Update readme

Change-Id: Icf4a66083f56d6f51be76ba1cf3b5dc8daf2c4c1

* Add readme

Change-Id: I2fbaa55092ef8787f1423d499aa310cab258c0c1

* Added parsers

* Final minor changes to parsers

* Added autogenerated README

* Changed snippets_test keyring name and cryptokey name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants