Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user_agent property to ClientInfo #7799

Merged
merged 2 commits into from
Apr 29, 2019

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Apr 24, 2019

This provides a way for partners to define a prefix identifying their
tool or application, as required by many cloud partnership agreements.

@tswast tswast requested a review from theacodes as a code owner April 24, 2019 20:25
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 24, 2019
@busunkim96
Copy link
Contributor

A pytype check is failing. (I don't think it's related to this change?)

[3/26] check google.api_core.datetime_helpers
FAILED: /tmpfs/src/github/google-cloud-python/api_core/pytype_output/pyi/google/api_core/datetime_helpers.pyi
pytype-single --imports_info /tmpfs/src/github/google-cloud-python/api_core/pytype_output/imports/google.api_core.datetime_helpers.imports --module-name google.api_core.datetime_helpers -V 3.6 -o /tmpfs/src/github/google-cloud-python/api_core/pytype_output/pyi/google/api_core/datetime_helpers.pyi --analyze-annotated --nofail --quick /tmpfs/src/github/google-cloud-python/api_core/google/api_core/datetime_helpers.py
File "/tmpfs/src/github/google-cloud-python/api_core/google/api_core/datetime_helpers.py", line 23, in <module>: Couldn't import pyi for 'google.protobuf.timestamp_pb2' [pyi-error]
  Can't find pyi for 'google.protobuf.descriptor_pb2.FieldOptions', referenced from 'google.protobuf.descriptor_pb2'
For more details, see https://google.github.io/pytype/errors.html#pyi-error.

@rchen152 Do you have any insight here?

@rchen152
Copy link
Contributor

It looks like you've been bitten by google/pytype#150 - pytype has trouble loading some third party pyi files, including the google.protobuf ones, it seems.

The easiest workaround is to add disable = pyi-error to the pytype section of setup.cfg.

This provides a way for partners to define a prefix identifying their
tool or application, as required by many cloud partnership agreements.
@tswast tswast merged commit a2c1f6c into googleapis:master Apr 29, 2019
@tswast tswast deleted the b116069533-user-agent-prefix branch April 29, 2019 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: core cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants