Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gcloud vendor and just use apitools code #811

Merged
merged 2 commits into from
Apr 9, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Apr 9, 2015

See #808 for previous discussion.

Fixes #755.

Labeled dont-merge for now because it depends on an un-released fix in apitools.

/cc @craigcitro

@dhermes dhermes added api: storage Issues related to the Cloud Storage API. packaging do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Apr 9, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 9, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f31ae34 on dhermes:remove-gcloud-vendor into 41b5b72 on GoogleCloudPlatform:master.

@craigcitro
Copy link
Contributor

and since the other PR is closed -- apitools release is done, so no more worry there.

@dhermes
Copy link
Contributor Author

dhermes commented Apr 9, 2015

Thanks for the release Craig! @tseaver PTAL, dont-merge label removed.

@dhermes dhermes removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 9, 2015
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 79332e1 on dhermes:remove-gcloud-vendor into * on GoogleCloudPlatform:master*.

@tseaver
Copy link
Contributor

tseaver commented Apr 9, 2015

LGTM

dhermes added a commit that referenced this pull request Apr 9, 2015
Remove gcloud vendor and just use `apitools` code
@dhermes dhermes merged commit f08e71b into googleapis:master Apr 9, 2015
@dhermes
Copy link
Contributor Author

dhermes commented Apr 9, 2015

@tseaver I'm gonna cut a release today or tomorrow

Stay in the 0.4 series or go to 0.5.0? (I vote the latter.)

@tseaver
Copy link
Contributor

tseaver commented Apr 9, 2015

I'd go with 0.5.0: we're including a new API, for instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DISCUSSION: Switch to apitools as a dependency
5 participants