-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KMS: Add 'options' arg to 'get_iam_policy'; pin black versoin (via synth). #8587
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…library generator.
yoshi-automation
added
the
api: cloudkms
Issues related to the Cloud Key Management Service API.
label
Jul 3, 2019
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Jul 3, 2019
tseaver
changed the title
[CHANGE ME] Re-generated kms to pick up changes in the API or client library generator.
KMS: Add 'options' arg to 'get_iam_policy'; pin black versoin (via synth).
Jul 3, 2019
tseaver
reviewed
Jul 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crwilcox, @busunkim96, @lukesneeringer, tests fail on this PR (and lots of the others created today), because it pulls in the options
argument for GetIamPolicy
added in this googleapis commit.
Before merging, we need a corresponding release of grpc-google-iam-v1
.
tseaver
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: cloudkms
Issues related to the Cloud Key Management Service API.
cla: yes
This human has signed the Contributor License Agreement.
codegen
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was generated using Autosynth. 🌈
Here's the log from Synthtool: