Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding namespace to dataset class. #934

Merged
merged 1 commit into from
Jun 23, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jun 22, 2015

This does not add support for namespace in _implicit_environ.

Related to #902.


As a result of #861 we will likely be removing _implicit_environ which makes this the actual resolution of #902.

/cc @jonparrott

This does not add support for namespace in `_implicit_environ`.

Related to googleapis#902.
@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Jun 22, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 22, 2015
@dhermes
Copy link
Contributor Author

dhermes commented Jun 22, 2015

FWIW I checked where namespace is used in the .proto API. It is only used in PartitionId (along with dataset_id) and the PartitionId message type is only used in Key and RunQueryRequest.

Accordingly, the only places we support namespace is:

  • Connection.run_query(dataset_id, query_pb, namespace=...)
  • Key(..., namespace=...)
  • Query(..., namespace=...)

@theacodes
Copy link
Contributor

Cool, as long as it's an option on the client class when that happens I'm satisfied.

@tseaver
Copy link
Contributor

tseaver commented Jun 23, 2015

LGTM. I plan to rename datastore.dataset.Dataset -> datastore.client.Client after this merges.

@dhermes
Copy link
Contributor Author

dhermes commented Jun 23, 2015

OK SGTM

dhermes added a commit that referenced this pull request Jun 23, 2015
@dhermes dhermes merged commit 88f7c83 into googleapis:master Jun 23, 2015
@dhermes dhermes deleted the add-name-space-to-dataset branch June 23, 2015 20:18
@dhermes dhermes mentioned this pull request Jul 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants