Update batch/transaction/query to hold client. #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update batch/transaction to push themselves onto client's stack, rather than batches. Updated API-invoking methods to take 'client', rather than 'connection', falling back to the client held by self. See #944.
googlebot
added
the
cla: yes
This was referenced Jul 10, 2015
| 'a dataset ID set.') | ||
|
|
||
| def __init__(self, client): | ||
| self._client = client |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
All finished with review, will await your comments. |
Do it once, rather than in each property invocation. Addresses: #978 (comment) #978 (comment)
|
@dhermes I think I have addressed everything. PTAL. |
|
LGTM |
tseaver
added a commit
that referenced
this pull request
Jul 11, 2015
…_client Update batch/transaction/query to hold client.
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Jul 21, 2015
See googleapis#978 for context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update batch/transaction to push themselves onto client's stack, rather
than batches.
Updated API-invoking methods to take 'client', rather than 'connection',
falling back to the client held by self.
See #944.