Skip to content

Commit

Permalink
Add unit tests
Browse files Browse the repository at this point in the history
  • Loading branch information
quartzmo committed May 28, 2019
1 parent 732a307 commit c53c68f
Show file tree
Hide file tree
Showing 2 changed files with 52 additions and 1 deletion.
2 changes: 1 addition & 1 deletion google-cloud-firestore/lib/google/cloud/firestore/query.rb
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class Query
attr_accessor :parent_path

##
# @private The Google::Firestore::V1::Query object.
# @private The Google::Firestore::V1::StructuredQuery object.
attr_accessor :query

##
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
# Copyright 2019 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

require "helper"

describe Google::Cloud::Firestore::Client, :col_group, :mock_firestore do
let(:collection_id) { "my-collection-id" }
let(:collection_id_bad) { "a/b/my-collection-id" }

it "creates a collection group query" do
query = firestore.col_group(collection_id).where "foo", "==", "bar"

query.must_be_kind_of Google::Cloud::Firestore::Query
query_gapi = query.query
query_gapi.must_be_kind_of Google::Firestore::V1::StructuredQuery
query_gapi.from.size.must_equal 1
query_gapi.from.first.must_be_kind_of Google::Firestore::V1::StructuredQuery::CollectionSelector
query_gapi.from.first.all_descendants.must_equal true
query_gapi.from.first.collection_id.must_equal collection_id
end

it "creates a collection group query using collection_group alias" do
query = firestore.collection_group(collection_id).where "foo", "==", "bar"

query.must_be_kind_of Google::Cloud::Firestore::Query
query_gapi = query.query
query_gapi.must_be_kind_of Google::Firestore::V1::StructuredQuery
query_gapi.from.size.must_equal 1
query_gapi.from.first.must_be_kind_of Google::Firestore::V1::StructuredQuery::CollectionSelector
query_gapi.from.first.all_descendants.must_equal true
query_gapi.from.first.collection_id.must_equal collection_id
end

it "raises when collection_id contains a forward slash" do
error = expect do
firestore.col_group collection_id_bad
end.must_raise ArgumentError
error.message.must_equal "Invalid collection_id: 'a/b/my-collection-id', must not contain '/'."
end
end

0 comments on commit c53c68f

Please sign in to comment.