chore: Fix tests by updating minitest version constraint #4115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
What do you think about capping Minitest in the Gemfile so the dependency doesn’t have to change? |
|
Hmm Logger still has some broken links in the generated docs. Investigating... |
|
@blowmage Yeah, that's a good idea. Means we wouldn't have to add a synth hack for generated gemspecs. I don't think any of the Gemfiles are generated. |
… links from codegen
|
Yay tests pass now. |
blowmage
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix the consistently failing tests (core, debugger, and logger).
~> 5.11.3to avoid incompatibilities in the5.12.xseries (and avoid the warnings printed by them).Note: I updated the minitest dependency only in those three libraries for now. This is just an attempt to get tests passing. It sounds like we still want to update it in the other libraries as well (which may involve synth work for generated gemspecs), as part of the work to address #4110.