Support Ruby 2.8 keyword arguments for google-cloud-storage

[yahonda]

This pull request supports Ruby 2.8 keyword arguments for google-cloud-storage

Fully separate positional arguments and keyword arguments support is required to use google-cloud-storage gem with currently developed Ruby 2.8.0-dev.

Note

• test/google/cloud/storage_test.rb failure will be addressed once the newer version of minitest is released including If a callable mock includes kwargs, Ruby 2.7 warns

• Workaround to force install grpc gem Refer Support for Ruby 2.7 grpc/grpc#21514 (comment)
  Note: This commit must be reverted once the newer version of grpc is released to rubygems.org including Add ruby-2.7 to build process of binary gems for Windows and Linux grpc/grpc#22039

[quartzmo]

Hi @yahonda,

Thank you for opening this PR. Do you have an urgent need for it to be merged?

[yahonda]

Thanks for the reply.

Let me update why I need this change, No urgency but it is important to prepare Ruby 3 and avoid warnings for Ruby 2.7 user.

google-cloud-storage gem is required for one of the major components of Ruby on Rails, called Active Storage. Ruby on Rails CI is running also with Ruby 2.8.0-dev and CI of Active Storage is failing likely because google-cloud-storage does not support the Ruby 3 keyword arguments yet.

• Active Storage CI with Ruby 2.8.0-dev - raise ArgumentError: wrong number of arguments

https://buildkite.com/rails/rails/builds/67309#0d0e7865-29ec-49a4-99cb-cdc7b7ea596f/942-1266

ArgumentError: wrong number of arguments (given 4, expected 2..3)

Also, Ruby 2.7 shows warnings if the code is not ready for Ruby 3 keyword arguments.

• Active Storage CI with Ruby 2.7.0 - show warnings about the keyword arguments:

https://buildkite.com/rails/rails/builds/67301#4b646278-fdf1-4e12-86bc-07ea4c2768c0/1008-1275

/usr/local/bundle/gems/google-cloud-storage-1.25.1/lib/google/cloud/storage/bucket.rb:1272: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call

I'd like to make Rails CI green as much as possible to prepare Ruby 3. Thanks.

[quartzmo]

Thanks for the detailed explanation. This makes perfect sense, and we will try to help solve your CI build problem as fast as we can. We are hoping that gRPC will be updated soon, so that possibly we can avoid the Bundler hacks in this PR. In addition, I am thinking that some of these conversions to double splats can just be converted to definite keyword args instead.

[quartzmo]

This library was originally written to support Ruby 1.9 (no longer supported), so there are places where options was used as a convenience and where it can now be replaced with a simple list of keyword args. However, there are also some options hashes that are quite large.

[quartzmo]

If you can remove the Bundler hacks (and wait for grpc to be updated, hopefully it won't be long), I am ready to approve this PR now with the following four small changes to use keyword args inline.

[quartzmo]

I found a few rubocop violations. Run rake rubocop or rake ci to check.

[quartzmo]

Here's a commit for my suggestions that you are welcome to include in this PR if it is helpful.

[googlebot]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[yahonda]

Thanks for the detailed review. I agree with your commit then cherry-pick quartzmo@76b815f and pushed to this pull request.

[quartzmo]

@googlebot I consent.

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[quartzmo]

@yahonda What do you think about removing the Bundler hacks in favor of waiting for a grpc update?

[yahonda]

Agreed. I have removed the bundler hack and squashed commits.

[quartzmo]

@yahonda Thank you very much for helping us with this!