Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(datastore): Update minitest to 5.14 #5580

Merged
merged 4 commits into from
Apr 20, 2020
Merged

chore(datastore): Update minitest to 5.14 #5580

merged 4 commits into from
Apr 20, 2020

Conversation

quartzmo
Copy link
Member

Use rubocop-minitest gem and bundle exec rubocop --only Minitest/GlobalExpectations -a to autocorrect minitest warnings for Ruby 2.7.

refs: #4110
refs: #4116

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 20, 2020
@quartzmo quartzmo requested a review from a team April 20, 2020 16:24
@quartzmo quartzmo self-assigned this Apr 20, 2020
@quartzmo quartzmo added the api: datastore Issues related to the Datastore API. label Apr 20, 2020
dazuma
dazuma approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request. Otherwise, LGTM.

google-cloud-datastore/Gemfile Outdated Show resolved Hide resolved
@quartzmo quartzmo merged commit 7d37d2b into googleapis:master Apr 20, 2020
@quartzmo quartzmo deleted the datastore-minitest-update branch April 20, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blowmage blowmage blowmage left review comments

@dazuma dazuma dazuma approved these changes

Assignees

@quartzmo quartzmo

Labels
api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@quartzmo @blowmage @dazuma @googlebot