Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Convert to markdown #193

Merged
merged 2 commits into from
Aug 3, 2018
Merged

Docs: Convert to markdown #193

merged 2 commits into from
Aug 3, 2018

Conversation

chingor13
Copy link
Contributor

Fixes #132
Fixes #151

@chingor13 chingor13 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 23, 2018
@chingor13 chingor13 requested a review from a team July 23, 2018 18:57
@jeanbza
Copy link
Member

jeanbza commented Jul 23, 2018

Seems ok to me.

@chingor13
Copy link
Contributor Author

Looks like the test failure is from the pom.xml specifying 1.24.0-SNAPSHOT for the http client.

@jeanbza
Copy link
Member

jeanbza commented Jul 23, 2018

Yeah, those are expected up until http-1.24.0 is out.

@jeanbza jeanbza removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 2, 2018
@jeanbza
Copy link
Member

jeanbza commented Aug 2, 2018

Could you rebase? I think tests should pass now.

@chingor13 chingor13 merged commit 123b055 into googleapis:dev Aug 3, 2018
@chingor13 chingor13 deleted the assembly-readme branch August 3, 2018 22:54
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanbza jeanbza jeanbza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chingor13 @jeanbza