Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement changes undone by #103 (always use raw response data) #106

Closed
crwilcox opened this issue Sep 17, 2019 · 3 comments · Fixed by #109
Closed

Reimplement changes undone by #103 (always use raw response data) #106

crwilcox opened this issue Sep 17, 2019 · 3 comments · Fixed by #109
Assignees
@tseaver
Labels
type: process A process-related concern. May include testing, release, or the like.

Comments

@crwilcox
Copy link
Collaborator

Changes originally merged in #87 were undone in #103 in a way that can be opted in to to avoid breaking usage by users on older client library versions. Particularly GCS
@crwilcox
Copy link
Collaborator Author

This issue over on GCS, googleapis/google-cloud-python#9188, seems to point to us making it more clear when we are decompressing and what the encoding is.

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Sep 18, 2019
@tseaver tseaver added type: process A process-related concern. May include testing, release, or the like. and removed triage me I really want to be triaged. labels Sep 18, 2019
@tseaver tseaver self-assigned this Sep 18, 2019
@tseaver
Copy link
Contributor

tseaver commented Sep 18, 2019

See PR #87. Note that redoing them is complicated by the fact that the code has since been blackened. :(

@tseaver tseaver mentioned this issue Sep 18, 2019
Closed
@tseaver
Copy link
Contributor

tseaver commented Sep 18, 2019 •
edited
Loading

Plan:

@tseaver tseaver mentioned this issue Sep 26, 2019
Merged
tseaver added a commit that referenced this issue Oct 28, 2019
@tseaver
feat: add raw download classes (#109)
0e541ce 
Closes #106.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add raw download classes
3 participants
@tseaver @crwilcox @yoshi-automation