-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add (optional) hash validation of objects #22
Comments
I'd like to add basic support for checksum validation for downloads, and would appreciate your thoughts about the proposed approach:
|
A first cut implementation that does checksumming for non-chunked, non-composite downloads is being reviewed at: The next big things that need to be done:
|
@dhermes @mfschwartz Would it make sense to check that the response code is not 206 before validating checksums? This fake-gcs-server includes checksums even for partial downloads, which seems to be within specification (judging by the orange box here). When those checksums are verified by this library, an error is thrown as the whole object is obviously not available to the client. |
Download
withstream
,requests
only (Add checksum validation for non-chunked non-composite downloads #32)Download
withstream
, generic transport (i.e in_download.py
)Download
without streamChunkedDownload
Download
(necessary for composite objects, though will be very slow unlesscrcmod
is used with C speedups) (feat: add configurable crc32c checksumming for downloads #135, includes warning for slowcrcmod
)Upload
hash checks (feat: add configurable checksum support for uploads #139)/cc @jonparrott
The text was updated successfully, but these errors were encountered: