Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use unittest.mock #329

Merged
merged 1 commit into from
May 24, 2022
Merged

fix: Use unittest.mock #329

merged 1 commit into from
May 24, 2022

Conversation

major
Copy link
Contributor

@major major commented May 19, 2022

The mock module is deprecated in recent Python versions.

Signed-off-by: Major Hayden [email protected]

Fixes #328 🦕

@major major requested review from a team as code owners May 19, 2022 14:06
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/google-resumable-media-python API. labels May 19, 2022
tests/system/requests/test_upload.py Outdated Show resolved Hide resolved
@major major changed the title fix: Use unittest.mock if available fix: Use unittest.mock May 19, 2022
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewsg
Copy link
Contributor

Unfortunately, tests are failing now due to the change to async. Go ahead and remove any changes to the async directory and I will clean it up later along with the rest of our experimental async infrastructure.

The `mock` module is deprecated in recent Python versions.

Signed-off-by: Major Hayden <[email protected]>
@major
Copy link
Contributor Author

major commented May 23, 2022

@andrewsg Done!

@cojenco cojenco added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 24, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 24, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 24, 2022
@andrewsg andrewsg merged commit 82f9769 into googleapis:main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/google-resumable-media-python API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use unittest.mock if available rather than deprecated mock module
4 participants