Using requests iter_content() to avoid storing response body in RAM.
#21
Conversation
| @@ -19,6 +19,9 @@ | |||
| from google.resumable_media.requests import _helpers | |||
|
|
|||
|
|
|||
| _SINGLE_GET_CHUNK_SIZE = 8192 | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
|
||
| Returns: | ||
| ~requests.Response: The return value of ``transport.request()``. | ||
| """ | ||
| func = functools.partial( | ||
| transport.request, method, url, data=data, headers=headers) | ||
| transport.request, method, url, data=data, headers=headers, | ||
| **transport_kwargs) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
I pushed the branch to the main project remote so the system tests would run: https://circleci.com/gh/GoogleCloudPlatform/google-resumable-media-python/176 |
|
This may not be the end of the road, I am currently playing around with failures after consuming part of the |
Fixes #5.
I'll be adding a system test to make extra double sure this code works as expected, but wanted to send out the PR before adding it.
/cc @tseaver since I can't add you as a reviewer