Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap the order of _write_to_stream() / _process_response() in requests download. #24

Merged
merged 1 commit into from
Aug 1, 2017
Merged

Swap the order of _write_to_stream() / _process_response() in requests download. #24

merged 1 commit into from
Aug 1, 2017

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Aug 1, 2017

Since this doesn't actually change the interface, none of the docs for latest/ or 0.2.2/ need be changed.

Once merged, I propose this commit be tagged as the NEW-AND-IMPROVED 0.2.2 release

/cc @tseaver

@tseaver
Copy link
Contributor

tseaver commented Aug 1, 2017

LGTM, including moving the 0.2.2 tag (since PyPI still has 0.2.1 as the latest release).

@dhermes dhermes merged commit fdaa12a into googleapis:master Aug 1, 2017
@dhermes dhermes deleted the swap-order-requests branch August 1, 2017 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes theacodes approved these changes

Assignees

@lukesneeringer lukesneeringer

@theacodes theacodes

Labels
download requests-transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhermes @tseaver @theacodes @lukesneeringer