Adding retries for **ANY** http request. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will always retry on 429, 500, 502, 503 and 504. Based on: https://cloud.google.com/storage/docs/json_api/v1/how-tos/resumable-upload#handling_errors
theacodes
reviewed
Apr 24, 2017
google/resumable_media/_helpers.py
Outdated
|
|
||
| total_sleep = 0.0 | ||
| num_retries = 0 | ||
| while total_sleep < MAX_CUMULATIVE_RETRY: |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@jonparrott Requested re-factor has been done. PTAL |
theacodes
reviewed
Apr 24, 2017
google/resumable_media/_helpers.py
Outdated
| Args: | ||
| func (Callable): A callable that takes no arguments and produces | ||
| a result which will be checked by ``predicate``. | ||
| predicate (Callable): Determines if the result is valid. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
theacodes
reviewed
Apr 24, 2017
| """Determines if a ``response`` is retryable. | ||
|
|
||
| Args: | ||
| object: The return value of ``transport.request()``. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
theacodes
approved these changes
Apr 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will always retry on 429, 500, 502, 503 and 504. Based on:
https://cloud.google.com/storage/docs/json_api/v1/how-tos/resumable-upload#handling_errors