Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further DRY request dependency pins. #96

Merged
merged 1 commit into from
Aug 28, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
SYSTEM_TEST_ENV_VARS = (
'GOOGLE_APPLICATION_CREDENTIALS',
)
REQUESTS = 'requests >= 2.18.0, < 3.0.0dev'
GOOGLE_AUTH = 'google-auth >= 0.10.0'


Expand All @@ -30,8 +29,8 @@ def unit_tests(session):
"""Run the unit test suite."""

# Install all test dependencies, then install this package in-place.
session.install('mock', 'pytest', 'pytest-cov', REQUESTS)
session.install('-e', '.')
session.install('mock', 'pytest', 'pytest-cov')
session.install('-e', '.[requests]')

# Run py.test against the unit tests.
# NOTE: We don't require 100% line coverage for unit test runs since
Expand Down Expand Up @@ -60,9 +59,8 @@ def docs(session):
'Sphinx == 2.1.2',
'sphinx_rtd_theme == 0.4.3',
'sphinx-docstring-typing >= 0.0.3',
REQUESTS,
)
session.install('-e', '.')
session.install('-e', '.[requests]')

# Build the docs!
session.run('bash', os.path.join('scripts', 'build_docs.sh'))
Expand All @@ -79,9 +77,8 @@ def doctest(session):
'sphinx-docstring-typing >= 0.0.3',
'mock',
GOOGLE_AUTH,
REQUESTS,
)
session.install('-e', '.')
session.install('-e', '.[requests]')

# Run the doctests with Sphinx.
session.run(
Expand Down Expand Up @@ -133,8 +130,8 @@ def system_tests(session):

# Install all test dependencies, then install this package into the
# virutalenv's dist-packages.
session.install('mock', 'pytest', REQUESTS, GOOGLE_AUTH)
session.install('-e', '.')
session.install('mock', 'pytest', GOOGLE_AUTH)
session.install('-e', '.[requests]')

# Run py.test against the system tests.
session.run(
Expand Down