Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add an unmanaged dependency check #2038

Merged
merged 12 commits into from
Jan 17, 2024
Merged

chore: add an unmanaged dependency check #2038

merged 12 commits into from
Jan 17, 2024

Conversation

JoeWang1127
Copy link
Contributor

@JoeWang1127 JoeWang1127 commented Dec 20, 2023 •
edited
Loading

In this PR:

  • Add an unmanaged dependency check to verify there's no dependency that is not covered by java shared dependencies (the latest released version in Maven Central).

When it fails, this throws error:

This pull request seems to add new third-party dependency, [com.h2database:h2], among the artifacts listed in google-cloud-bigtable-bom/pom.xml.
Please see go/cloud-sdk-java-dependency-governance.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Dec 20, 2023
@JoeWang1127 JoeWang1127 added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed api: bigtable Issues related to the googleapis/java-bigtable API. labels Dec 20, 2023
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Dec 21, 2023
@JoeWang1127 JoeWang1127 changed the title chore: add a check chore: add an unmanaged dependency check Jan 10, 2024
@JoeWang1127 JoeWang1127 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 10, 2024
@JoeWang1127 JoeWang1127 marked this pull request as ready for review January 10, 2024 20:37
@JoeWang1127 JoeWang1127 requested review from a team as code owners January 10, 2024 20:37
@JoeWang1127 JoeWang1127 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2024
@JoeWang1127 JoeWang1127 merged commit 7c963da into main Jan 17, 2024
24 checks passed
@JoeWang1127 JoeWang1127 deleted the chore/add-unmanaged-dependency-check branch January 17, 2024 17:50
mutianf pushed a commit to mutianf/java-bigtable that referenced this pull request Feb 6, 2024
@JoeWang1127 @mutianf
chore: add an unmanaged dependency check (googleapis#2038)
b4e5a6d 
* chore: add a check

* add a working directory

* add action.yaml directory

* change mvn command

* add shell

* change target

* change target

* change target

* change tag

* add an unmanaged dependency to verify the check

* remove test scope

* remove dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolea2 kolea2 kolea2 approved these changes

@suztomo suztomo Awaiting requested review from suztomo

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoeWang1127 @suztomo @kolea2