feat: support overriding the emulator download URL in LocalDatastoreHelper #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: datastore
google-cla
bot
added
the
cla: yes
aristide-n
added a commit
to aristide-n/java-core
that referenced
this pull request
Aug 9, 2021
aristide-n
commented
Aug 9, 2021
| @@ -147,7 +153,7 @@ private LocalDatastoreHelper(Builder builder) { | |||
| gcloudCommand.add("--data-dir=" + getGcdPath()); | |||
| } | |||
| DownloadableEmulatorRunner downloadRunner = | |||
| new DownloadableEmulatorRunner(binCommand, EMULATOR_URL, MD5_CHECKSUM); | |||
| new DownloadableEmulatorRunner(binCommand, EMULATOR_URL, MD5_CHECKSUM, ACCESS_TOKEN); | |||
There was a problem hiding this comment.
requires a google-java-core dependency version that contains googleapis/java-core#513
lesv
pushed a commit
to googleapis/java-core
that referenced
this pull request
Aug 16, 2021
…513) * feat: support downloading an emulator from an access controlled URL fixes googleapis/java-datastore#376 used in googleapis/java-datastore#492 * fix format
lesv
added
the
kokoro:force-run
|
/gcbrun |
yoshi-kokoro
removed
the
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
lesv
approved these changes
Aug 17, 2021
chingor13
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
chingor13
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 1, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [2.1.0](https://www.github.com/googleapis/java-datastore/compare/v2.0.3...v2.1.0) (2021-08-31) ### Features * support overriding the emulator download URL in LocalDatastoreHelper ([#492](https://www.github.com/googleapis/java-datastore/issues/492)) ([76397bf](https://www.github.com/googleapis/java-datastore/commit/76397bf7ce27804101a1622e82f436cac0dcd605)), closes [#376](https://www.github.com/googleapis/java-datastore/issues/376) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.2.0 ([#524](https://www.github.com/googleapis/java-datastore/issues/524)) ([81b9de5](https://www.github.com/googleapis/java-datastore/commit/81b9de5b8bc6e788618b2530a9f47ca97aa30d98)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo
pushed a commit
to googleapis/sdk-platform-java
that referenced
this pull request
Mar 21, 2023
…513) * feat: support downloading an emulator from an access controlled URL fixes googleapis/java-datastore#376 used in googleapis/java-datastore#492 * fix format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #376