Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix clirr check failure #1841

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Fix: fix clirr check failure #1841

merged 2 commits into from
Sep 20, 2024

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Sep 20, 2024

A feature branch that marks CustomClassMapper public has been reverted, and this is causing clirr check to fail.

@milaGGL milaGGL requested review from a team as code owners September 20, 2024 16:23
Copy link

conventional-commit-lint-gcf bot commented Sep 20, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/java-firestore API. labels Sep 20, 2024
@tom-andersen tom-andersen assigned milaGGL and unassigned tom-andersen Sep 20, 2024
@tom-andersen tom-andersen added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 20, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 20, 2024
@milaGGL milaGGL added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 20, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 20, 2024
@milaGGL milaGGL merged commit b8b995f into main Sep 20, 2024
23 of 24 checks passed
@milaGGL milaGGL deleted the mila/fix-clirr-error branch September 20, 2024 19:27
lqiu96 pushed a commit that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/java-firestore API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants