Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update DatabaseMetaData to include named schemas #1733

Merged
merged 1 commit into from
Sep 2, 2024
Merged

feat: update DatabaseMetaData to include named schemas #1733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/main/java/com/google/cloud/spanner/jdbc/JdbcDatabaseMetaData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,27 +419,27 @@ public String getCatalogSeparator() {

@Override
public boolean supportsSchemasInDataManipulation() {
return false;
return true;
}

@Override
public boolean supportsSchemasInProcedureCalls() {
return false;
return true;
}

@Override
public boolean supportsSchemasInTableDefinitions() {
return false;
return true;
}

@Override
public boolean supportsSchemasInIndexDefinitions() {
return false;
return true;
}

@Override
public boolean supportsSchemasInPrivilegeDefinitions() {
return false;
return true;
}

@Override
Expand Down Expand Up @@ -602,7 +602,7 @@ public int getMaxIndexLength() {

@Override
public int getMaxSchemaNameLength() {
return 0;
return 128;
}

@Override
Expand Down
12 changes: 6 additions & 6 deletions src/test/java/com/google/cloud/spanner/jdbc/JdbcDatabaseMetaDataTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ public void testTrivialMethods() throws SQLException {
assertEquals(8000, meta.getMaxIndexLength());
assertEquals(0, meta.getMaxProcedureNameLength());
assertEquals(0, meta.getMaxRowSize());
assertEquals(0, meta.getMaxSchemaNameLength());
assertEquals(128, meta.getMaxSchemaNameLength());
assertEquals(1000000, meta.getMaxStatementLength());
assertEquals(0, meta.getMaxStatements());
assertEquals(128, meta.getMaxTableNameLength());
Expand Down Expand Up @@ -245,11 +245,11 @@ public void testTrivialMethods() throws SQLException {
assertTrue(meta.supportsResultSetHoldability(ResultSet.CLOSE_CURSORS_AT_COMMIT));
assertFalse(meta.supportsResultSetHoldability(ResultSet.HOLD_CURSORS_OVER_COMMIT));
assertFalse(meta.supportsSavepoints());
assertFalse(meta.supportsSchemasInDataManipulation());
assertFalse(meta.supportsSchemasInIndexDefinitions());
assertFalse(meta.supportsSchemasInPrivilegeDefinitions());
assertFalse(meta.supportsSchemasInProcedureCalls());
assertFalse(meta.supportsSchemasInTableDefinitions());
assertTrue(meta.supportsSchemasInDataManipulation());
assertTrue(meta.supportsSchemasInIndexDefinitions());
assertTrue(meta.supportsSchemasInPrivilegeDefinitions());
assertTrue(meta.supportsSchemasInProcedureCalls());
assertTrue(meta.supportsSchemasInTableDefinitions());
assertFalse(meta.supportsSelectForUpdate());
assertFalse(meta.supportsStatementPooling());
assertFalse(meta.supportsStoredFunctionsUsingCallSyntax());
Expand Down
Loading