Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document thread safety of library #1566

Merged
merged 2 commits into from
Aug 12, 2022
Merged

Conversation

JesseLovelace
Copy link
Contributor

Internal bug 216304555, documents the thread safety of this library

@JesseLovelace JesseLovelace requested a review from a team as a code owner August 11, 2022 21:47
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/java-storage API. labels Aug 11, 2022
@JesseLovelace JesseLovelace changed the title Document thread safety of library docs: Document thread safety of library Aug 11, 2022
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Copy link
Collaborator

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hoping to address the lack of thread safety for Read/Write Channel along with the gRPC work. If that works, we can try to backport the same approach to the JSON implementation.

@JesseLovelace JesseLovelace merged commit c740899 into main Aug 12, 2022
@JesseLovelace JesseLovelace deleted the documentthreadsafety branch August 12, 2022 17:26
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 15, 2022
🤖 I have created a release *beep* *boop*
---


## [2.12.0](v2.11.3...v2.12.0) (2022-09-15)


### Features

* Add toString method for CustomPlacementConfig ([#1602](#1602)) ([51aca10](51aca10))


### Documentation

* Add batch sample ([#1559](#1559)) ([583bf73](583bf73))
* Document thread safety of library ([#1566](#1566)) ([c740899](c740899))
* Fix broken links in readme ([#1520](#1520)) ([840b08a](840b08a))


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#1611](#1611)) ([8a48aea](8a48aea))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#1620](#1620)) ([20e6378](20e6378))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants