Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement GrpcStorageImpl#*HmacKey #1576

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Conversation

BenWhitehead
Copy link
Collaborator

  • GrpcStorageImpl#createHmacKey
  • GrpcStorageImpl#getHmacKey
  • GrpcStorageImpl#updateHmacKey
  • GrpcStorageImpl#deleteHmacKey

Add tests for each Hmac method to ITGrpcTest

Depends on #1568

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/java-storage API. labels Aug 19, 2022
Base automatically changed from remove-zopt to feat/grpc-storage August 19, 2022 17:42
* GrpcStorageImpl#createHmacKey
* GrpcStorageImpl#getHmacKey
* GrpcStorageImpl#updateHmacKey
* GrpcStorageImpl#deleteHmacKey

Add tests for each Hmac method to ITGrpcTest
@BenWhitehead BenWhitehead marked this pull request as ready for review August 19, 2022 18:13
@BenWhitehead BenWhitehead requested a review from a team as a code owner August 19, 2022 18:13
@BenWhitehead BenWhitehead merged commit 84e4adf into feat/grpc-storage Aug 23, 2022
@BenWhitehead BenWhitehead deleted the hmac-ops branch August 23, 2022 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants