Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update routing annotation for CreateBucketRequest #1892

Merged
merged 4 commits into from
Feb 8, 2023
Merged

feat: Update routing annotation for CreateBucketRequest #1892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
504bea0
feat: Update routing annotation for CreateBucketRequest
gcf-owl-bot[bot] Feb 7, 2023
6311728
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 7, 2023
83905d0
chore: update clirr config
BenWhitehead Feb 8, 2023
1352ef1
chore: update usages of Notification to NotificationConfig
BenWhitehead Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions gapic-google-cloud-storage-v2/clirr-ignored-differences.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,20 @@
<className>com/google/storage/v2/stub/HttpJsonStorageStub</className>
</difference>

<!-- Allow rename from Notification to NotificationConfig-->
<difference>
<differenceType>7002</differenceType>
<className>com/google/storage/v2/*</className>
<method>* *Notification*(*)</method>
</difference>
<difference>
<differenceType>7002</differenceType>
<className>com/google/storage/v2/stub/*</className>
<method>* *Notification*(*)</method>
</difference>
<difference>
<differenceType>8001</differenceType>
<className>com/google/storage/v2/StorageClient$ListNotification*</className>
</difference>

</differences>
390 changes: 211 additions & 179 deletions gapic-google-cloud-storage-v2/src/main/java/com/google/storage/v2/StorageClient.java
View file
Open in desktop

Large diffs are not rendered by default.

67 changes: 37 additions & 30 deletions gapic-google-cloud-storage-v2/src/main/java/com/google/storage/v2/StorageSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

import static com.google.storage.v2.StorageClient.ListBucketsPagedResponse;
import static com.google.storage.v2.StorageClient.ListHmacKeysPagedResponse;
import static com.google.storage.v2.StorageClient.ListNotificationsPagedResponse;
import static com.google.storage.v2.StorageClient.ListNotificationConfigsPagedResponse;
import static com.google.storage.v2.StorageClient.ListObjectsPagedResponse;

import com.google.api.core.ApiFunction;
Expand Down Expand Up @@ -132,26 +132,31 @@ public UnaryCallSettings<UpdateBucketRequest, Bucket> updateBucketSettings() {
return ((StorageStubSettings) getStubSettings()).updateBucketSettings();
}

/** Returns the object with the settings used for calls to deleteNotification. */
public UnaryCallSettings<DeleteNotificationRequest, Empty> deleteNotificationSettings() {
return ((StorageStubSettings) getStubSettings()).deleteNotificationSettings();
/** Returns the object with the settings used for calls to deleteNotificationConfig. */
public UnaryCallSettings<DeleteNotificationConfigRequest, Empty>
deleteNotificationConfigSettings() {
return ((StorageStubSettings) getStubSettings()).deleteNotificationConfigSettings();
}

/** Returns the object with the settings used for calls to getNotification. */
public UnaryCallSettings<GetNotificationRequest, Notification> getNotificationSettings() {
return ((StorageStubSettings) getStubSettings()).getNotificationSettings();
/** Returns the object with the settings used for calls to getNotificationConfig. */
public UnaryCallSettings<GetNotificationConfigRequest, NotificationConfig>
getNotificationConfigSettings() {
return ((StorageStubSettings) getStubSettings()).getNotificationConfigSettings();
}

/** Returns the object with the settings used for calls to createNotification. */
public UnaryCallSettings<CreateNotificationRequest, Notification> createNotificationSettings() {
return ((StorageStubSettings) getStubSettings()).createNotificationSettings();
/** Returns the object with the settings used for calls to createNotificationConfig. */
public UnaryCallSettings<CreateNotificationConfigRequest, NotificationConfig>
createNotificationConfigSettings() {
return ((StorageStubSettings) getStubSettings()).createNotificationConfigSettings();
}

/** Returns the object with the settings used for calls to listNotifications. */
/** Returns the object with the settings used for calls to listNotificationConfigs. */
public PagedCallSettings<
ListNotificationsRequest, ListNotificationsResponse, ListNotificationsPagedResponse>
listNotificationsSettings() {
return ((StorageStubSettings) getStubSettings()).listNotificationsSettings();
ListNotificationConfigsRequest,
ListNotificationConfigsResponse,
ListNotificationConfigsPagedResponse>
listNotificationConfigsSettings() {
return ((StorageStubSettings) getStubSettings()).listNotificationConfigsSettings();
}

/** Returns the object with the settings used for calls to composeObject. */
Expand Down Expand Up @@ -389,29 +394,31 @@ public UnaryCallSettings.Builder<UpdateBucketRequest, Bucket> updateBucketSettin
return getStubSettingsBuilder().updateBucketSettings();
}

/** Returns the builder for the settings used for calls to deleteNotification. */
public UnaryCallSettings.Builder<DeleteNotificationRequest, Empty>
deleteNotificationSettings() {
return getStubSettingsBuilder().deleteNotificationSettings();
/** Returns the builder for the settings used for calls to deleteNotificationConfig. */
public UnaryCallSettings.Builder<DeleteNotificationConfigRequest, Empty>
deleteNotificationConfigSettings() {
return getStubSettingsBuilder().deleteNotificationConfigSettings();
}

/** Returns the builder for the settings used for calls to getNotification. */
public UnaryCallSettings.Builder<GetNotificationRequest, Notification>
getNotificationSettings() {
return getStubSettingsBuilder().getNotificationSettings();
/** Returns the builder for the settings used for calls to getNotificationConfig. */
public UnaryCallSettings.Builder<GetNotificationConfigRequest, NotificationConfig>
getNotificationConfigSettings() {
return getStubSettingsBuilder().getNotificationConfigSettings();
}

/** Returns the builder for the settings used for calls to createNotification. */
public UnaryCallSettings.Builder<CreateNotificationRequest, Notification>
createNotificationSettings() {
return getStubSettingsBuilder().createNotificationSettings();
/** Returns the builder for the settings used for calls to createNotificationConfig. */
public UnaryCallSettings.Builder<CreateNotificationConfigRequest, NotificationConfig>
createNotificationConfigSettings() {
return getStubSettingsBuilder().createNotificationConfigSettings();
}

/** Returns the builder for the settings used for calls to listNotifications. */
/** Returns the builder for the settings used for calls to listNotificationConfigs. */
public PagedCallSettings.Builder<
ListNotificationsRequest, ListNotificationsResponse, ListNotificationsPagedResponse>
listNotificationsSettings() {
return getStubSettingsBuilder().listNotificationsSettings();
ListNotificationConfigsRequest,
ListNotificationConfigsResponse,
ListNotificationConfigsPagedResponse>
listNotificationConfigsSettings() {
return getStubSettingsBuilder().listNotificationConfigsSettings();
}

/** Returns the builder for the settings used for calls to composeObject. */
Expand Down
Loading