Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change Prefix to Download Directory #1975

Merged
merged 4 commits into from
Apr 12, 2023

Conversation

sydney-munro
Copy link
Collaborator

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@sydney-munro sydney-munro requested a review from a team as a code owner April 11, 2023 17:02
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Apr 11, 2023
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Apr 11, 2023
Copy link
Collaborator

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two very minor things, feel free to merge after acknowledgement.

sydney-munro and others added 3 commits April 12, 2023 09:01
…ansfermanager/ParallelDownloadConfig.java

Co-authored-by: BenWhitehead <[email protected]>
…ansfermanager/ParallelDownloadConfig.java

Co-authored-by: BenWhitehead <[email protected]>
@sydney-munro sydney-munro added the automerge Merge the pull request once unit tests and other checks pass. label Apr 12, 2023
@gcf-merge-on-green
Copy link

Your PR doesn't have any required checks. Please add required checks to your feat/transfer-manager branch and then re-add the label. Learn more about enabling these checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks.

@sydney-munro sydney-munro merged commit 63e6d52 into feat/transfer-manager Apr 12, 2023
@sydney-munro sydney-munro deleted the error-handling branch April 12, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. automerge Merge the pull request once unit tests and other checks pass. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants