feat: Resolve API futures on getDownload/UploadResults calls #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
BenWhitehead
approved these changes
Jun 13, 2023
| @@ -39,8 +41,8 @@ private DownloadJob( | |||
| this.parallelDownloadConfig = parallelDownloadConfig; | |||
| } | |||
|
|
|||
| public @NonNull List<ApiFuture<DownloadResult>> getDownloadResults() { | |||
| return downloadResults; | |||
| public @NonNull List<DownloadResult> getDownloadResults() { | |||
There was a problem hiding this comment.
When we add javadocs, we will want to be sure to mention these methods are blocking.
sydney-munro
force-pushed
the
resolve-api-futures
branch
from
4cafd2d
to
a2ebc96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the public API we will resolve the API Futures and return the result (ie. await the resolution and return the result).