Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(samples): update Autoclass Sample for v2.1 features #2259

Merged
merged 1 commit into from
Oct 27, 2023
Merged

chore(samples): update Autoclass Sample for v2.1 features #2259

merged 1 commit into from
Oct 27, 2023

Conversation

BenWhitehead
Copy link
Collaborator

Depends on #2258

@BenWhitehead BenWhitehead added do not merge Indicates a pull request not ready for merge, due to either quality or timing. owlbot:ignore instruct owl-bot to ignore a PR labels Oct 16, 2023
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. labels Oct 16, 2023
@BenWhitehead BenWhitehead linked an issue Oct 16, 2023 that may be closed by this pull request
Add support for Autoclass v2.1 #2212
Closed
@BenWhitehead BenWhitehead mentioned this pull request Oct 16, 2023
Closed
lesv
lesv approved these changes Oct 16, 2023
View reviewed changes
Copy link

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No test? Otherwise LGTM

cojenco
cojenco reviewed Oct 16, 2023
View reviewed changes
Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Could we also update the storage_get_autoclass sample to demonstrate the newly added fields?

https://github.com/googleapis/java-storage/blob/main/samples/snippets/src/main/java/com/example/storage/bucket/GetBucketAutoclass.java

samples/snippets/src/main/java/com/example/storage/bucket/SetBucketAutoclass.java Outdated Show resolved Hide resolved
samples/snippets/src/main/java/com/example/storage/bucket/SetBucketAutoclass.java Outdated Show resolved Hide resolved
Base automatically changed from feat/autoclass to main October 18, 2023 18:39
@BenWhitehead BenWhitehead requested a review from a team as a code owner October 18, 2023 18:39
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Oct 27, 2023
@BenWhitehead BenWhitehead removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 27, 2023
@BenWhitehead
Copy link
Collaborator Author

Now that libraries-bom has been released with the feature I've rebased and updated the sample and the samples test.

@cojenco I applied the value changes in the sample you recommended.

@cojenco
Copy link
Contributor

cojenco commented Oct 27, 2023

Thanks for working on this! Could we also update the storage_get_autoclass sample to demonstrate the newly added fields?

https://github.com/googleapis/java-storage/blob/main/samples/snippets/src/main/java/com/example/storage/bucket/GetBucketAutoclass.java

LGTM, could we showcase the new fields in the get_autoclass sample too? Thank you @BenWhitehead

cojenco
cojenco approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks Ben 🙂

@BenWhitehead BenWhitehead merged commit 332f70b into main Oct 27, 2023
18 checks passed
@BenWhitehead BenWhitehead deleted the samples/autoclass branch October 27, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cojenco cojenco cojenco approved these changes

@lesv lesv lesv approved these changes

Assignees

@lesv lesv

Labels
api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Autoclass v2.1
3 participants
@BenWhitehead @cojenco @lesv