Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused image tag in .OwlBot-hermetic.yaml #2695

Merged
merged 1 commit into from
Sep 5, 2024
Merged

chore: remove unused image tag in .OwlBot-hermetic.yaml #2695

merged 1 commit into from
Sep 5, 2024

Conversation

diegomarquezp
Copy link
Contributor

This removes the unused image tag in this file. Part of the cleanup after enabling Hermetic Library generation in this repo.

@diegomarquezp
chore: remove unused image tag in .OwlBot-hermetic.yaml
baabf67 
This removes the unused image tag in this file. Part of the cleanup after enabling Hermetic Library generation in this repo.

Newline at EOF automatically added - see [this SO](https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline).
@diegomarquezp diegomarquezp requested review from a team as code owners September 5, 2024 14:41
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/java-storage API. labels Sep 5, 2024
@diegomarquezp
Copy link
Contributor Author

Integration test failing with

[ERROR] Tests run: 46, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 13.10 s <<< FAILURE! -- in com.google.cloud.storage.it.ITBlobReadChannelTest
[ERROR] com.google.cloud.storage.it.ITBlobReadChannelTest.optionsWork[GRPC][PROD] -- Time elapsed: 0.262 s <<< FAILURE!
expected any of: [304, 409]
but was        : 412
	at com.google.cloud.storage.it.ITBlobReadChannelTest.optionsWork(ITBlobReadChannelTest.java:321)

It's possibly a flake. It also occurred in #2694

@diegomarquezp diegomarquezp merged commit d91ad84 into main Sep 5, 2024
20 of 21 checks passed
@diegomarquezp diegomarquezp deleted the diegomarquezp-patch-1 branch September 5, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

@JoeWang1127 JoeWang1127 Awaiting requested review from JoeWang1127

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/java-storage API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diegomarquezp @blakeli0