Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable Token Retries #481

Merged
merged 2 commits into from
Feb 1, 2024
Merged

feat: Enable Token Retries #481

merged 2 commits into from
Feb 1, 2024

Conversation

danielbankhead
Copy link
Member

Should provide relief from all of the ECONNRESET flakiness we've seen recently.

🦕

@TimurSadykov
Copy link
Member

@danielbankhead Hey, does this mark retryable 500, 503, 408, 429 as described in go/auth-correct-retry?

@danielbankhead
Copy link
Member Author

It’s missing 408 (the others are handled by default), however this service endpoint has severed connections causing ECONNRESET errors for us and customers. We needed a short-term fix until we’re unblocked rolling out the updated endpoints (the every other lang use):

I’ll roll out the additional auth retry implementation here and in auth shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants