Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add wrapper for reading table data using Storage API #431
feat: add wrapper for reading table data using Storage API #431
Changes from 27 commits
485b33d
39d3370
1ef1c9b
4bf1511
45a4afa
aa57c03
72afe00
7a5847a
6b98711
77fff01
98546f3
bd67c85
aaeb3bd
9fa976a
7382c34
63805b3
182d323
ac0a018
26d5b95
456f2d4
a02c634
4b41b3e
d266408
0d1af64
88449ea
f811ead
898ae4b
6a86580
872f0f3
052713b
94886cc
6b9f68c
67baeca
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment as others about the any
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this many streams piped, it is probably better to use
pipeline
with a common error handler for them - otherwise you run the risk for errors getting swallowed in between the various pipe calls.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll check how to use the
pipeline
method, that's new to me.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried to use
pipeline
, but is meant to be used when we have a destination. In this case where, we are just applying a bunch of transforms and we don't know the destination beforehand.The error that I got:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am envisioning something like
or
then you'd return that outputStream - are you thinking of something different? I won't die on this hill, but I really got burned by pipes recently and want to save you from that experience
Check warning on line 29 in src/reader/arrow_transform.ts
GitHub Actions / lint
Check warning on line 159 in src/reader/arrow_transform.ts
GitHub Actions / lint
Check warning on line 159 in src/reader/arrow_transform.ts
GitHub Actions / lint
Check warning on line 163 in src/reader/arrow_transform.ts
GitHub Actions / lint