Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make samples test work #113

Merged
merged 1 commit into from
May 31, 2018
Merged

Conversation

alexander-fenster
Copy link
Contributor

Fixing samples tests CI broken since yesterday.

I made a mistake manually editing this config file yesterday, fixing it. npm link will not work using non-root account unless this variable is defined.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

I made a mistake manually editing this config file yesterday, fixing it. `npm link` will not work using non-root account unless this variable is defined.
@codecov
Copy link

codecov bot commented May 31, 2018

Codecov Report

Merging #113 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #113   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         696    696           
=====================================
  Hits          696    696

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c560653...c490a66. Read the comment docs.

@stephenplusplus stephenplusplus merged commit 549eb28 into master May 31, 2018
@stephenplusplus stephenplusplus deleted the alexander-fenster-patch-1 branch May 31, 2018 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants