Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly pass autoPaginate: false to query methods. #121

Merged
merged 2 commits into from
Jun 22, 2018

Conversation

stephenplusplus
Copy link
Contributor

Fixes #120

cc @jimkang

@codecov
Copy link

codecov bot commented Jun 20, 2018

Codecov Report

Merging #121 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #121   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         704    709    +5     
=====================================
+ Hits          704    709    +5
Impacted Files Coverage Δ
src/job.js 100% <100%> (ø) ⬆️
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1606313...c1cc3b3. Read the comment docs.

@jimkang
Copy link

jimkang commented Jun 21, 2018

Thank you! I'd love to see this merged. In the meantime, I'll see if I can try this branch directly.

@stephenplusplus stephenplusplus merged commit 4183693 into googleapis:master Jun 22, 2018
@stephenplusplus stephenplusplus deleted the spp--120 branch June 22, 2018 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants