Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (tests) Use a filter to locate datasets used in tests. #177

Merged
merged 1 commit into from
Aug 28, 2018
Merged

fix: (tests) Use a filter to locate datasets used in tests. #177

merged 1 commit into from
Aug 28, 2018

Conversation

stephenplusplus
Copy link
Contributor

Fixes #176

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 27, 2018
@ghost ghost assigned stephenplusplus Aug 27, 2018
jkwlui
jkwlui approved these changes Aug 28, 2018
View reviewed changes
Copy link
Member

@jkwlui jkwlui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@jkwlui
Copy link
Member

jkwlui commented Aug 28, 2018

Please continue to ignore kokoro failures. It's not properly configured here yet.

@JustinBeckwith JustinBeckwith merged commit ec54375 into googleapis:master Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@jkwlui jkwlui jkwlui approved these changes

@callmehiphop callmehiphop Awaiting requested review from callmehiphop

Assignees

@stephenplusplus stephenplusplus

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephenplusplus @jkwlui @JustinBeckwith @googlebot