Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(typescript): convert index to es module #227

Merged
merged 4 commits into from
Oct 26, 2018
Merged

refactor(typescript): convert index to es module #227

merged 4 commits into from
Oct 26, 2018

Conversation

JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented Oct 25, 2018 •
edited
Loading

BREAKING CHANGE: The import style of this library has been changed to be es module compatible.

Old Code

const BigQuery = require('@google-cloud/bigquery');
const bigquery = new BigQuery();

New Code

const {BigQuery} = require('@google-cloud/bigquery');
const bigquery = new BigQuery();

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 25, 2018
JustinBeckwith
JustinBeckwith commented Oct 25, 2018
View reviewed changes
test/index.ts
@@ -410,13 +420,13 @@ describe('BigQuery', () => {
day: 1,
};

it('should expose static and instance constructors', () => {
it.skip('should expose static and instance constructors', () => {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@JustinBeckwith JustinBeckwith mentioned this pull request Oct 25, 2018
Closed
jkwlui
jkwlui reviewed Oct 26, 2018
View reviewed changes
src/table.ts
@@ -18,7 +18,7 @@

import * as arrify from 'arrify';
import * as Big from 'big.js';
import {ServiceObject, util, SetMetadataResponse, ResponseCallback} from '@google-cloud/common';
import * as common from '@google-cloud/common';

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@jkwlui jkwlui mentioned this pull request Oct 26, 2018
Closed
@JustinBeckwith
Copy link
Contributor Author

Tip to reviewers @kinwa91 @stephenplusplus - you probably want to add ?w=1 in the url to filter out all the whitespace junk and noise:
https://github.com/googleapis/nodejs-bigquery/pull/227/files?w=1

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2018
jkwlui
jkwlui reviewed Oct 26, 2018
View reviewed changes
package.json
@@ -57,7 +57,6 @@
"benchmark": "time node benchmark/bench.js benchmark/queries.json",
"docs": "jsdoc -c .jsdoc.js",
"lint": "eslint samples/",

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@JustinBeckwith JustinBeckwith merged commit fcbc07b into googleapis:master Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkwlui jkwlui jkwlui left review comments

@stephenplusplus stephenplusplus stephenplusplus approved these changes

@callmehiphop callmehiphop Awaiting requested review from callmehiphop

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JustinBeckwith @stephenplusplus @jkwlui @googlebot @kokoro-team