Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs-bigquery - convert samples test ava to mocha #248

Merged
merged 10 commits into from
Nov 22, 2018

Conversation

vijay-qlogic
Copy link
Contributor

Fixes #Convert all sample tests to mocha (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 1, 2018
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 2, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 2, 2018
samples/package.json Show resolved Hide resolved
samples/system-test/datasets.test.js Show resolved Hide resolved
samples/system-test/quickstart.test.js Show resolved Hide resolved
samples/system-test/quickstart.test.js Show resolved Hide resolved
samples/system-test/quickstart.test.js Outdated Show resolved Hide resolved
samples/system-test/quickstart.test.js Outdated Show resolved Hide resolved
@JustinBeckwith
Copy link
Contributor

👋 gentle ping

@vijay-qlogic vijay-qlogic force-pushed the ava-to-mocha branch 2 times, most recently from 2d4c9a1 to bde4be0 Compare November 15, 2018 14:35
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 15, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 15, 2018
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2018
@vijay-qlogic
Copy link
Contributor Author

@JustinBeckwith strange! locally all tests passing form me, but not here

@JustinBeckwith
Copy link
Contributor

So this will sound crazy. Try pinning @types/sinon to version 5.0.5 with no range specifier, and see if it works.

@JustinBeckwith
Copy link
Contributor

Heh apologies - I meant in the root package.json, not samples/package.json

@vijay-qlogic
Copy link
Contributor Author

Worked 👍

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 20, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 20, 2018
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 22, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 22, 2018
@JustinBeckwith JustinBeckwith merged commit 834b18f into googleapis:master Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants