Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve timestamp documentation. #280

Merged
merged 4 commits into from
Dec 4, 2018
Merged

Conversation

crwilcox
Copy link
Contributor

@crwilcox crwilcox commented Dec 3, 2018

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 3, 2018
src/index.ts Outdated
@@ -585,7 +585,7 @@ export class BigQuery extends common.Service {
* zone or convention such as Daylight Savings Time.
*
* @method BigQuery#timestamp
* @param {date} value The time.
* @param {date} value The time represented by a `Date` or `string`

This comment was marked as spam.

This comment was marked as spam.

@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2018
@JustinBeckwith JustinBeckwith merged commit 1cf49c3 into master Dec 4, 2018
@jmdobry jmdobry deleted the crwilcox-patch-1 branch December 5, 2018 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants