Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): move comments above last overload #292

Merged
merged 3 commits into from
Dec 7, 2018
Merged

Conversation

jkwlui
Copy link
Member

@jkwlui jkwlui commented Dec 6, 2018

during typescript compilation, the comments above the first overload gets stripped off. The doc comments need to be placed right above the last overload.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 6, 2018
@jkwlui jkwlui requested a review from crwilcox December 6, 2018 22:33
@jkwlui jkwlui merged commit 80d8218 into master Dec 7, 2018
@stephenplusplus stephenplusplus deleted the fix-overload-jsdoc branch February 26, 2019 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants