Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly iterate query results within stream #323

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

stephenplusplus
Copy link
Contributor

Fixes #303

In a stream, we-- y'know what, @oliverwoodings explained it best: #303 (comment)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 8, 2019
@oliverwoodings
Copy link

Woo! Thanks for the amazingly fast fix. Glad you were able to follow my code diving :)

@@ -1513,6 +1517,10 @@ export class BigQuery extends common.Service {
* @private
*/
queryAsStream_(query: Query, callback?: SimpleQueryRowsCallback) {
if (query.job) {
query.job.getQueryResults(query, callback as QueryRowsCallback);

This comment was marked as spam.

@stephenplusplus
Copy link
Contributor Author

@oliverwoodings it's your patience going through all of that that is most impressive :D

@JustinBeckwith JustinBeckwith merged commit 734e4e2 into googleapis:master Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants