Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip installation test if GOOGLE_CLOUD_TESTS_IN_VPCSC is passed #345

Merged
merged 12 commits into from
Feb 15, 2019

Conversation

jkwlui
Copy link
Member

@jkwlui jkwlui commented Feb 5, 2019

Split out install-test as a separate npm run-script instead of bundling
with system-test.

This helps unblock VPCSC testing since it can't fetch external
dependencies with npm install when installation test does npm pack

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 5, 2019
@jkwlui jkwlui requested a review from a team February 5, 2019 22:57
@jkwlui jkwlui self-assigned this Feb 5, 2019
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this - could we do the thing you did in storage where we looked for an env var, and did an explicit skip? I don't want the kokoro configs straying if we can at all avoid it.

@jkwlui
Copy link
Member Author

jkwlui commented Feb 7, 2019

I changed it to use the environment variable to determine whether or not to skip install-test, but I still kept it split out

@jkwlui jkwlui changed the title test: split out installation test from system-test test: skip installation test if GOOGLE_CLOUD_TESTS_IN_VPCSC is passed Feb 7, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Feb 12, 2019
@codecov
Copy link

codecov bot commented Feb 14, 2019

Codecov Report

Merging #345 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #345   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files           4        4           
  Lines         544      544           
  Branches       75       75           
=======================================
  Hits          541      541           
  Misses          2        2           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6ad9d7...503cad8. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit 7558880 into master Feb 15, 2019
@stephenplusplus stephenplusplus deleted the split-out-install-test branch February 26, 2019 14:45
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants