fix(types): move JobLoadMetadata writeDisposition

[arjenvanderende]

The writeDisposition field for interface JobLoadMetadata appears to have been defined incorrectly; it does not belong under timePartitioning.

Typescript fails to compile if I define it under the root, but works as expected if I cast the options to any like so:

new BigQuery({ projectId: "my-project-id" })
    .dataset("my_dataset")
    .table("my_table")
    .load("my_file.csv", {
        format: "csv",
        writeDisposition: "WRITE_TRUNCATE",
    } as any);

See:
https://cloud.google.com/bigquery/docs/reference/rest/v2/jobs#configuration.load

• Tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)

[stephenplusplus]

Thank you!

[stephenplusplus]

Thank you for this. Would you mind taking out the specific string values, however? The upstream is the official resource for acceptable values, and we don't want to duplicate from this layer in the event it is changed upstream.

[arjenvanderende]

No problem. I think it improves typing, but I understand your reasoning for wanting to keep it simple.

Keep in mind, I copied the definitions from CopyTableMetadata which also includes specific string values. 😉
See: https://github.com/googleapis/nodejs-bigquery/blob/master/src/table.ts#L151-L157

I changed the type back to an optional string and amended/rebased the commit.

[stephenplusplus]

Oh, gotcha. I didn't realize it was there, too! Thank you for all of the help!

[codecov]

Codecov Report

Merging #365 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #365   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files           4        4           
  Lines         544      544           
  Branches       75       75           
=======================================
  Hits          541      541           
  Misses          2        2           
  Partials        1        1

Impacted Files	Coverage Δ
src/table.ts	100% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 444ef11...94e9fd3. Read the comment docs.