testing: remove nextQuery assertion #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
JustinBeckwith
approved these changes
Mar 11, 2019
bcoe
approved these changes
Mar 11, 2019
| @@ -176,7 +176,6 @@ describe('BigQuery', () => { | |||
| filter: `labels.${GCLOUD_TESTS_PREFIX}`, | |||
| }); | |||
| assert(datasets[0] instanceof Dataset); | |||
| assert.strictEqual(nextQuery, null); | |||
There was a problem hiding this comment.
seems reasonable to me; in a perfect world, I might try to have a beforeEach that ensures that there's nothing populated in nextQuery before running the test. Is there a tracking issue for this bug? (state between tests can really start to be a pain).
There was a problem hiding this comment.
I don't think there is, @JustinBeckwith might know though?
Codecov Report
@@ Coverage Diff @@
## master #377 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 4 4
Lines 544 544
Branches 75 75
=======================================
Hits 541 541
Misses 2 2
Partials 1 1Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #375
Since we refactored our strategy for dealing with lingering resources, sometimes
nextQuerywill be populated with a page of resources from a different test run.