Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(samples): fix loadJSONFromGCSTruncate wrong function #386

Merged
merged 6 commits into from
Mar 17, 2019
Merged

refactor(samples): fix loadJSONFromGCSTruncate wrong function #386

merged 6 commits into from
Mar 17, 2019

Conversation

steffnay
Copy link
Contributor

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 17, 2019
@steffnay steffnay requested a review from jkwlui March 17, 2019 01:55
@JustinBeckwith
Copy link
Contributor

It looks like we introduced 404's in the docs with the previous samples change. Would you mind submitting a PR to address those first, so the CI goes green?

@codecov
Copy link

codecov bot commented Mar 17, 2019

Codecov Report

Merging #386 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #386   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files           4        4           
  Lines         544      544           
  Branches       75       75           
=======================================
  Hits          541      541           
  Misses          2        2           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fcd1c9...179d430. Read the comment docs.

@steffnay steffnay merged commit cb44357 into googleapis:master Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants