Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: AuditConfig for IAM v1 #1061

Merged
merged 5 commits into from
Apr 5, 2022
Merged

feat: AuditConfig for IAM v1 #1061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
27b0197
docs: Update `cpu_utilization_percent` limit
gcf-owl-bot[bot] Mar 30, 2022
8b18320
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Mar 30, 2022
1c70b65
feat: AuditConfig for IAM v1
gcf-owl-bot[bot] Apr 4, 2022
e8f69fe
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Apr 4, 2022
39eb2e8
Merge branch 'main' into owl-bot-copy
gcf-merge-on-green[bot] Apr 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions protos/google/bigtable/admin/v2/instance.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,8 @@ message Instance {
message AutoscalingTargets {
// The cpu utilization that the Autoscaler should be trying to achieve.
// This number is on a scale from 0 (no utilization) to
// 100 (total utilization).
// 100 (total utilization), and is limited between 10 and 80, otherwise it
// will return INVALID_ARGUMENT error.
int32 cpu_utilization_percent = 2;
}

Expand Down Expand Up @@ -165,7 +166,6 @@ message Cluster {
// `cloudkms.cryptoKeyEncrypterDecrypter` role on the CMEK key.
// 2) Only regional keys can be used and the region of the CMEK key must
// match the region of the cluster.
// 3) All clusters within an instance must use the same CMEK key.
string kms_key_name = 1 [(google.api.resource_reference) = {
type: "cloudkms.googleapis.com/CryptoKey"
}];
Expand Down
2 changes: 1 addition & 1 deletion samples/generated/v2/bigtable_instance_admin.get_iam_policy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ function main(resource) {
// const resource = 'abc123'
/**
* OPTIONAL: A `GetPolicyOptions` object for specifying options to
* `GetIamPolicy`. This field is only used by Cloud IAM.
* `GetIamPolicy`.
*/
// const options = {}

Expand Down
7 changes: 7 additions & 0 deletions samples/generated/v2/bigtable_instance_admin.set_iam_policy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,13 @@ function main(resource, policy) {
* might reject them.
*/
// const policy = {}
/**
* OPTIONAL: A FieldMask specifying which fields of the policy to modify. Only
* the fields in the mask will be modified. If no mask is provided, the
* following default mask is used:
* `paths: "bindings, etag"`
*/
// const updateMask = {}

// Imports the Admin library
const {BigtableInstanceAdminClient} = require('@google-cloud/bigtable').v2;
Expand Down
2 changes: 1 addition & 1 deletion samples/generated/v2/bigtable_table_admin.get_iam_policy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ function main(resource) {
// const resource = 'abc123'
/**
* OPTIONAL: A `GetPolicyOptions` object for specifying options to
* `GetIamPolicy`. This field is only used by Cloud IAM.
* `GetIamPolicy`.
*/
// const options = {}

Expand Down
7 changes: 7 additions & 0 deletions samples/generated/v2/bigtable_table_admin.set_iam_policy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,13 @@ function main(resource, policy) {
* might reject them.
*/
// const policy = {}
/**
* OPTIONAL: A FieldMask specifying which fields of the policy to modify. Only
* the fields in the mask will be modified. If no mask is provided, the
* following default mask is used:
* `paths: "bindings, etag"`
*/
// const updateMask = {}

// Imports the Admin library
const {BigtableTableAdminClient} = require('@google-cloud/bigtable').v2;
Expand Down
12 changes: 10 additions & 2 deletions samples/generated/v2/snippet_metadata.google.bigtable.admin.v2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,7 +858,7 @@
"segments": [
{
"start": 25,
"end": 59,
"end": 66,
"type": "FULL"
}
],
Expand All @@ -874,6 +874,10 @@
{
"name": "policy",
"type": ".google.iam.v1.Policy"
},
{
"name": "update_mask",
"type": ".google.protobuf.FieldMask"
}
],
"resultType": ".google.iam.v1.Policy",
Expand Down Expand Up @@ -1918,7 +1922,7 @@
"segments": [
{
"start": 25,
"end": 59,
"end": 66,
"type": "FULL"
}
],
Expand All @@ -1934,6 +1938,10 @@
{
"name": "policy",
"type": ".google.iam.v1.Policy"
},
{
"name": "update_mask",
"type": ".google.protobuf.FieldMask"
}
],
"resultType": ".google.iam.v1.Policy",
Expand Down
8 changes: 7 additions & 1 deletion src/v2/bigtable_instance_admin_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1383,7 +1383,7 @@ export class BigtableInstanceAdminClient {
* See the operation documentation for the appropriate value for this field.
* @param {google.iam.v1.GetPolicyOptions} request.options
* OPTIONAL: A `GetPolicyOptions` object for specifying options to
* `GetIamPolicy`. This field is only used by Cloud IAM.
* `GetIamPolicy`.
* @param {object} [options]
* Call options. See {@link https://googleapis.dev/nodejs/google-gax/latest/interfaces/CallOptions.html|CallOptions} for more details.
* @returns {Promise} - The promise which resolves to an array.
Expand Down Expand Up @@ -1474,6 +1474,12 @@ export class BigtableInstanceAdminClient {
* the policy is limited to a few 10s of KB. An empty policy is a
* valid policy but certain Cloud Platform services (such as Projects)
* might reject them.
* @param {google.protobuf.FieldMask} request.updateMask
* OPTIONAL: A FieldMask specifying which fields of the policy to modify. Only
* the fields in the mask will be modified. If no mask is provided, the
* following default mask is used:
*
* `paths: "bindings, etag"`
* @param {object} [options]
* Call options. See {@link https://googleapis.dev/nodejs/google-gax/latest/interfaces/CallOptions.html|CallOptions} for more details.
* @returns {Promise} - The promise which resolves to an array.
Expand Down
8 changes: 7 additions & 1 deletion src/v2/bigtable_table_admin_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1590,7 +1590,7 @@ export class BigtableTableAdminClient {
* See the operation documentation for the appropriate value for this field.
* @param {google.iam.v1.GetPolicyOptions} request.options
* OPTIONAL: A `GetPolicyOptions` object for specifying options to
* `GetIamPolicy`. This field is only used by Cloud IAM.
* `GetIamPolicy`.
* @param {object} [options]
* Call options. See {@link https://googleapis.dev/nodejs/google-gax/latest/interfaces/CallOptions.html|CallOptions} for more details.
* @returns {Promise} - The promise which resolves to an array.
Expand Down Expand Up @@ -1681,6 +1681,12 @@ export class BigtableTableAdminClient {
* the policy is limited to a few 10s of KB. An empty policy is a
* valid policy but certain Cloud Platform services (such as Projects)
* might reject them.
* @param {google.protobuf.FieldMask} request.updateMask
* OPTIONAL: A FieldMask specifying which fields of the policy to modify. Only
* the fields in the mask will be modified. If no mask is provided, the
* following default mask is used:
*
* `paths: "bindings, etag"`
* @param {object} [options]
* Call options. See {@link https://googleapis.dev/nodejs/google-gax/latest/interfaces/CallOptions.html|CallOptions} for more details.
* @returns {Promise} - The promise which resolves to an array.
Expand Down