Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: skip failing Windows test #1285

Merged
merged 2 commits into from
May 22, 2023
Merged

test: skip failing Windows test #1285

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8388168
test: skip failing Windows test
alexander-fenster May 20, 2023
1e17319
Merge branch 'main' into sinon-buffer-from-windows
alexander-fenster May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion test/mutation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,12 @@ describe('Bigtable/Mutation', () => {
assert.strictEqual(decoded.toString(), message);
});

it('should not create a new Buffer needlessly', () => {
it('should not create a new Buffer needlessly', function () {
if (process.platform === 'win32') {
// stubbing Buffer.from does not work on Windows since sinon 15.1.0
// TODO(@alexander-fenster): investigate and report or fix
this.skip();
}
const message = 'Hello!';
const encoded = Buffer.from(message);
const stub = sandbox.stub(Buffer, 'from');
Expand Down