-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure that during resumption of a scan, rows that have not been observed by the caller are re-requested #1444
Merged
danieljbruce
merged 35 commits into
googleapis:main
from
danieljbruce:fix-missing-rows-with-test-and-fix-for-node-14-plus-watermark-removal
Jul 11, 2024
Merged
Commits on Jul 9, 2024
-
fix: dropping buffered rows during a retry of a scan
createReadStream() creates a pipeline of streams that converts a stream of row chunks into a stream of logical rows. It also has logic to handle stream resumption when a single attempt fails. The pipeline can be split into 2 parts: the persistent operation stream that the caller sees and the transient per attempt segment. When a retry attempt occurs, the per attempt segment is unpiped from the operation stream and is discarded. Currently this includes any buffered data that each stream might contain. Unfortunately, when constructing the retry request, createReadStream() will use the last row key from the last buffered row. This will cause the buffered rows to be omitted from the operation stream. This PR fixes the missing rows part by only referencing the row keys that were seen by the persistent operation stream when constructing a retry attempt. In other words, this will ensure that we only update the lastSeenRow key once the row has been "committed" to the persistent portion of the pipeline
Configuration menu - View commit details
-
Copy full SHA for 9e2c037 - Browse repository at this point
Copy the full SHA 9e2c037View commit details
Commits on Jul 10, 2024
-
Add a test that sends rows back
# Conflicts: # system-test/read-rows.ts
Configuration menu - View commit details
-
Copy full SHA for 2a4d928 - Browse repository at this point
Copy the full SHA 2a4d928View commit details -
Create an instance with dummy server.
# Conflicts: # system-test/read-rows.ts
Configuration menu - View commit details
-
Copy full SHA for d8e2e91 - Browse repository at this point
Copy the full SHA d8e2e91View commit details -
Configuration menu - View commit details
-
Copy full SHA for d803684 - Browse repository at this point
Copy the full SHA d803684View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8bebb1 - Browse repository at this point
Copy the full SHA a8bebb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for fdc5c0d - Browse repository at this point
Copy the full SHA fdc5c0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 80f4fca - Browse repository at this point
Copy the full SHA 80f4fcaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 580d65f - Browse repository at this point
Copy the full SHA 580d65fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b08288a - Browse repository at this point
Copy the full SHA b08288aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e4d9b86 - Browse repository at this point
Copy the full SHA e4d9b86View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d41781 - Browse repository at this point
Copy the full SHA 9d41781View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d9b603 - Browse repository at this point
Copy the full SHA 2d9b603View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bad7c0 - Browse repository at this point
Copy the full SHA 5bad7c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e61343d - Browse repository at this point
Copy the full SHA e61343dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 138d105 - Browse repository at this point
Copy the full SHA 138d105View commit details -
Configuration menu - View commit details
-
Copy full SHA for f35fc3e - Browse repository at this point
Copy the full SHA f35fc3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for bf74092 - Browse repository at this point
Copy the full SHA bf74092View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff13036 - Browse repository at this point
Copy the full SHA ff13036View commit details -
Configuration menu - View commit details
-
Copy full SHA for 87c57a9 - Browse repository at this point
Copy the full SHA 87c57a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09d9155 - Browse repository at this point
Copy the full SHA 09d9155View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89c7c53 - Browse repository at this point
Copy the full SHA 89c7c53View commit details
Commits on Jul 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f60e790 - Browse repository at this point
Copy the full SHA f60e790View commit details -
Configuration menu - View commit details
-
Copy full SHA for d07aa9e - Browse repository at this point
Copy the full SHA d07aa9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 537760b - Browse repository at this point
Copy the full SHA 537760bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 96f98d7 - Browse repository at this point
Copy the full SHA 96f98d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b03b84 - Browse repository at this point
Copy the full SHA 7b03b84View commit details -
Configuration menu - View commit details
-
Copy full SHA for cffcd57 - Browse repository at this point
Copy the full SHA cffcd57View commit details -
Configuration menu - View commit details
-
Copy full SHA for 52675d1 - Browse repository at this point
Copy the full SHA 52675d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c62ed72 - Browse repository at this point
Copy the full SHA c62ed72View commit details -
Co-authored-by: Leah E. Cole <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d78d119 - Browse repository at this point
Copy the full SHA d78d119View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c0726c - Browse repository at this point
Copy the full SHA 8c0726cView commit details -
Configuration menu - View commit details
-
Copy full SHA for eba2195 - Browse repository at this point
Copy the full SHA eba2195View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a86df7 - Browse repository at this point
Copy the full SHA 0a86df7View commit details -
Merge branch 'fix-missing-rows-with-test-and-fix-for-node-14-plus-wat…
…ermark-removal' of https://github.com/danieljbruce/nodejs-bigtable into fix-missing-rows-with-test-and-fix-for-node-14-plus-watermark-removal
Configuration menu - View commit details
-
Copy full SHA for 85901e5 - Browse repository at this point
Copy the full SHA 85901e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88236d1 - Browse repository at this point
Copy the full SHA 88236d1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.