-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Get retries using GAX working in CBT client #1494
base: main
Are you sure you want to change the base?
feat: Get retries using GAX working in CBT client #1494
Commits on Jun 30, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a9b8d1b - Browse repository at this point
Copy the full SHA a9b8d1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f1b9eb - Browse repository at this point
Copy the full SHA 0f1b9ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for c75b4ed - Browse repository at this point
Copy the full SHA c75b4edView commit details
Commits on Jul 4, 2022
-
Configuration menu - View commit details
-
Copy full SHA for fcbd461 - Browse repository at this point
Copy the full SHA fcbd461View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2f4dfe - Browse repository at this point
Copy the full SHA c2f4dfeView commit details -
Revert "Pull request opts into a separate function"
This reverts commit c2f4dfe.
Configuration menu - View commit details
-
Copy full SHA for 4817863 - Browse repository at this point
Copy the full SHA 4817863View commit details -
Configuration menu - View commit details
-
Copy full SHA for 810db82 - Browse repository at this point
Copy the full SHA 810db82View commit details -
Merge branch 'actually-refactor-createreadstream-2' of https://github…
….com/danieljbruce/nodejs-bigtable into actually-refactor-createreadstream-3
Configuration menu - View commit details
-
Copy full SHA for 648cc92 - Browse repository at this point
Copy the full SHA 648cc92View commit details -
Revert "Revert "Pull request opts into a separate function""
This reverts commit 4817863.
Configuration menu - View commit details
-
Copy full SHA for b25b2c2 - Browse repository at this point
Copy the full SHA b25b2c2View commit details
Commits on Apr 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1b1947a - Browse repository at this point
Copy the full SHA 1b1947aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 59b2c26 - Browse repository at this point
Copy the full SHA 59b2c26View commit details
Commits on Apr 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for baa5d8f - Browse repository at this point
Copy the full SHA baa5d8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 869d5ce - Browse repository at this point
Copy the full SHA 869d5ceView commit details -
- Transform the rowsLimit parameter into an integer - Change the hook into a before hook so that we don’t attempt to create multiple mock servers - Create a guard so that the stream only writes if there are row keys to write
Configuration menu - View commit details
-
Copy full SHA for 5e69834 - Browse repository at this point
Copy the full SHA 5e69834View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf29061 - Browse repository at this point
Copy the full SHA bf29061View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad36097 - Browse repository at this point
Copy the full SHA ad36097View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c57e61 - Browse repository at this point
Copy the full SHA 2c57e61View commit details
Commits on Apr 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 95b9463 - Browse repository at this point
Copy the full SHA 95b9463View commit details
Commits on Apr 19, 2024
-
Merge branch 'main' of https://github.com/googleapis/nodejs-bigtable …
…into move-retries-from-createreadstream # Conflicts: # src/table.ts # src/utils/table.ts
Configuration menu - View commit details
-
Copy full SHA for 1c66b3b - Browse repository at this point
Copy the full SHA 1c66b3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6324ad9 - Browse repository at this point
Copy the full SHA 6324ad9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f51ddf - Browse repository at this point
Copy the full SHA 8f51ddfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5edaf82 - Browse repository at this point
Copy the full SHA 5edaf82View commit details
Commits on Apr 22, 2024
-
Revert "Add splice ranges back to diagnose problem"
This reverts commit 5edaf82.
Configuration menu - View commit details
-
Copy full SHA for 575ae2b - Browse repository at this point
Copy the full SHA 575ae2bView commit details -
readRowsReqOpts should have an ECMAscript prefix to completely hide it from the user. Also remove a useless Filter.parse.
Configuration menu - View commit details
-
Copy full SHA for 0f80c35 - Browse repository at this point
Copy the full SHA 0f80c35View commit details -
Configuration menu - View commit details
-
Copy full SHA for b46f6b1 - Browse repository at this point
Copy the full SHA b46f6b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 577ba7a - Browse repository at this point
Copy the full SHA 577ba7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 03fb022 - Browse repository at this point
Copy the full SHA 03fb022View commit details -
Configuration menu - View commit details
-
Copy full SHA for 752bf0b - Browse repository at this point
Copy the full SHA 752bf0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4989fa4 - Browse repository at this point
Copy the full SHA 4989fa4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f66d43 - Browse repository at this point
Copy the full SHA 1f66d43View commit details -
Merge branch 'createreadstream-with-mock-server' of https://github.co…
…m/danieljbruce/nodejs-bigtable into move-retries-createreadstream-just-getting-retries-working
Configuration menu - View commit details
-
Copy full SHA for 92d157e - Browse repository at this point
Copy the full SHA 92d157eView commit details -
Service error or Google error for this function
Also uncommented retry logic to see how the test would behave.
Configuration menu - View commit details
-
Copy full SHA for 70391d6 - Browse repository at this point
Copy the full SHA 70391d6View commit details
Commits on Apr 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 23919c5 - Browse repository at this point
Copy the full SHA 23919c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for abcf0fc - Browse repository at this point
Copy the full SHA abcf0fcView commit details -
Get rid of the any suppressed by typescript
It was necessary to add guards to make this work. Also changed the error type to Google error.
Configuration menu - View commit details
-
Copy full SHA for 07ec565 - Browse repository at this point
Copy the full SHA 07ec565View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85a0317 - Browse repository at this point
Copy the full SHA 85a0317View commit details
Commits on Apr 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 286e782 - Browse repository at this point
Copy the full SHA 286e782View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4136c1 - Browse repository at this point
Copy the full SHA f4136c1View commit details
Commits on Apr 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 22c3e0e - Browse repository at this point
Copy the full SHA 22c3e0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 84ff48e - Browse repository at this point
Copy the full SHA 84ff48eView commit details -
Refactor the test so that it is easy to
Move the check out into a separate function.
Configuration menu - View commit details
-
Copy full SHA for bedd060 - Browse repository at this point
Copy the full SHA bedd060View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1046b7 - Browse repository at this point
Copy the full SHA e1046b7View commit details -
Do not append retryRequestOptions to gax options
Appending retryRequestOptions will not work for any call that is also passing in the retry gax parameter.
Configuration menu - View commit details
-
Copy full SHA for 5c1063a - Browse repository at this point
Copy the full SHA 5c1063aView commit details -
Factor out the retry options logic
Move functions out of table.ts that other methods should not be concerned with. Export the function that creates retry logic from this new module
Configuration menu - View commit details
-
Copy full SHA for 2b0907e - Browse repository at this point
Copy the full SHA 2b0907eView commit details -
Rename the file to retry-options
This is going to be used by the mutate row retry options so the filename should not be so specific.
Configuration menu - View commit details
-
Copy full SHA for 706f972 - Browse repository at this point
Copy the full SHA 706f972View commit details
Commits on Apr 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 24de509 - Browse repository at this point
Copy the full SHA 24de509View commit details
Commits on May 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bb28fbd - Browse repository at this point
Copy the full SHA bb28fbdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1599215 - Browse repository at this point
Copy the full SHA 1599215View commit details -
Keep the resumption strategy in table.ts for now
There is currently a proxyquire issue preventing us from moving code out of table.ts so make a TODO and move it later.
Configuration menu - View commit details
-
Copy full SHA for a298ed2 - Browse repository at this point
Copy the full SHA a298ed2View commit details -
Move the resumption strategy back to its own file and get the proxyquire configs right so that tests pass.
Configuration menu - View commit details
-
Copy full SHA for 9f47d67 - Browse repository at this point
Copy the full SHA 9f47d67View commit details -
Configuration menu - View commit details
-
Copy full SHA for 133d024 - Browse repository at this point
Copy the full SHA 133d024View commit details -
Configuration menu - View commit details
-
Copy full SHA for 992da84 - Browse repository at this point
Copy the full SHA 992da84View commit details
Commits on May 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 18a31ce - Browse repository at this point
Copy the full SHA 18a31ceView commit details -
This ensures the right parameters are passed along to the gapic layer.
Configuration menu - View commit details
-
Copy full SHA for 15cd425 - Browse repository at this point
Copy the full SHA 15cd425View commit details
Commits on May 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2277d39 - Browse repository at this point
Copy the full SHA 2277d39View commit details -
Configuration menu - View commit details
-
Copy full SHA for e69a1da - Browse repository at this point
Copy the full SHA e69a1daView commit details -
Some issue with the mock server is making it so that responses don’t get sent back the way they should. This change allows all the tests to pass.
Configuration menu - View commit details
-
Copy full SHA for e4a505e - Browse repository at this point
Copy the full SHA e4a505eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 916ae95 - Browse repository at this point
Copy the full SHA 916ae95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3930703 - Browse repository at this point
Copy the full SHA 3930703View commit details -
Configuration menu - View commit details
-
Copy full SHA for a425264 - Browse repository at this point
Copy the full SHA a425264View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd1d1ac - Browse repository at this point
Copy the full SHA bd1d1acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 687b2e5 - Browse repository at this point
Copy the full SHA 687b2e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0612c97 - Browse repository at this point
Copy the full SHA 0612c97View commit details -
Configuration menu - View commit details
-
Copy full SHA for 18c8f3c - Browse repository at this point
Copy the full SHA 18c8f3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 372fec5 - Browse repository at this point
Copy the full SHA 372fec5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54d5255 - Browse repository at this point
Copy the full SHA 54d5255View commit details -
Configuration menu - View commit details
-
Copy full SHA for b95f87c - Browse repository at this point
Copy the full SHA b95f87cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 51a1a72 - Browse repository at this point
Copy the full SHA 51a1a72View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec4fc3c - Browse repository at this point
Copy the full SHA ec4fc3cView commit details
Commits on May 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 784882f - Browse repository at this point
Copy the full SHA 784882fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1621494 - Browse repository at this point
Copy the full SHA 1621494View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56905b2 - Browse repository at this point
Copy the full SHA 56905b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 67b7558 - Browse repository at this point
Copy the full SHA 67b7558View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34784eb - Browse repository at this point
Copy the full SHA 34784ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for f27d99e - Browse repository at this point
Copy the full SHA f27d99eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 03f1ada - Browse repository at this point
Copy the full SHA 03f1adaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b09f90 - Browse repository at this point
Copy the full SHA 2b09f90View commit details -
Configuration menu - View commit details
-
Copy full SHA for a45103e - Browse repository at this point
Copy the full SHA a45103eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ff55cd - Browse repository at this point
Copy the full SHA 1ff55cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f5afff - Browse repository at this point
Copy the full SHA 3f5afffView commit details -
Configuration menu - View commit details
-
Copy full SHA for f53d146 - Browse repository at this point
Copy the full SHA f53d146View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c70297 - Browse repository at this point
Copy the full SHA 9c70297View commit details -
Configuration menu - View commit details
-
Copy full SHA for fdb239e - Browse repository at this point
Copy the full SHA fdb239eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d28b496 - Browse repository at this point
Copy the full SHA d28b496View commit details -
Configuration menu - View commit details
-
Copy full SHA for e582747 - Browse repository at this point
Copy the full SHA e582747View commit details -
Configuration menu - View commit details
-
Copy full SHA for e662526 - Browse repository at this point
Copy the full SHA e662526View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48f2d30 - Browse repository at this point
Copy the full SHA 48f2d30View commit details
Commits on May 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b8f3457 - Browse repository at this point
Copy the full SHA b8f3457View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9aaf51 - Browse repository at this point
Copy the full SHA e9aaf51View commit details -
Pull functions out of TableUtils
These functions do not need to exist as a static method. Put them in the readrows resumption module.
Configuration menu - View commit details
-
Copy full SHA for ca23492 - Browse repository at this point
Copy the full SHA ca23492View commit details -
Configuration menu - View commit details
-
Copy full SHA for e450989 - Browse repository at this point
Copy the full SHA e450989View commit details -
Moved some unit tests over to the system test json file.
Configuration menu - View commit details
-
Copy full SHA for a2dde5b - Browse repository at this point
Copy the full SHA a2dde5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b0050c8 - Browse repository at this point
Copy the full SHA b0050c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea648e3 - Browse repository at this point
Copy the full SHA ea648e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d814b2 - Browse repository at this point
Copy the full SHA 0d814b2View commit details -
should not retry if limit is reached should remove the keys which were already read 'should remove ranges which were already read
Configuration menu - View commit details
-
Copy full SHA for a0b04b2 - Browse repository at this point
Copy the full SHA a0b04b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b44c48 - Browse repository at this point
Copy the full SHA 7b44c48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8380fd7 - Browse repository at this point
Copy the full SHA 8380fd7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 96e2bf1 - Browse repository at this point
Copy the full SHA 96e2bf1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04c1c6a - Browse repository at this point
Copy the full SHA 04c1c6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 75e3763 - Browse repository at this point
Copy the full SHA 75e3763View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b84895 - Browse repository at this point
Copy the full SHA 9b84895View commit details -
Configuration menu - View commit details
-
Copy full SHA for 257764c - Browse repository at this point
Copy the full SHA 257764cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e3a9bbb - Browse repository at this point
Copy the full SHA e3a9bbbView commit details -
Configuration menu - View commit details
-
Copy full SHA for f8d2150 - Browse repository at this point
Copy the full SHA f8d2150View commit details -
Configuration menu - View commit details
-
Copy full SHA for c32d1d9 - Browse repository at this point
Copy the full SHA c32d1d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab32da5 - Browse repository at this point
Copy the full SHA ab32da5View commit details
Commits on May 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7a2beea - Browse repository at this point
Copy the full SHA 7a2beeaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 10dc585 - Browse repository at this point
Copy the full SHA 10dc585View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab67124 - Browse repository at this point
Copy the full SHA ab67124View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22b6ffc - Browse repository at this point
Copy the full SHA 22b6ffcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3834e5c - Browse repository at this point
Copy the full SHA 3834e5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for a46899c - Browse repository at this point
Copy the full SHA a46899cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 98efacf - Browse repository at this point
Copy the full SHA 98efacfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 72a4ee3 - Browse repository at this point
Copy the full SHA 72a4ee3View commit details -
Configuration menu - View commit details
-
Copy full SHA for cad8da2 - Browse repository at this point
Copy the full SHA cad8da2View commit details -
Configuration menu - View commit details
-
Copy full SHA for f40566e - Browse repository at this point
Copy the full SHA f40566eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b00d7ea - Browse repository at this point
Copy the full SHA b00d7eaView commit details
Commits on May 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 80cf68c - Browse repository at this point
Copy the full SHA 80cf68cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 32fe3e5 - Browse repository at this point
Copy the full SHA 32fe3e5View commit details -
Add latency measurements to mock server tests
This commit contains a tool useful for printing latency results.
Configuration menu - View commit details
-
Copy full SHA for d3d05a2 - Browse repository at this point
Copy the full SHA d3d05a2View commit details -
Revert "Add latency measurements to mock server tests"
This reverts commit d3d05a2.
Configuration menu - View commit details
-
Copy full SHA for 9efd250 - Browse repository at this point
Copy the full SHA 9efd250View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01bdccb - Browse repository at this point
Copy the full SHA 01bdccbView commit details -
Revert "Rename the comment as a TODO"
This reverts commit 80cf68c.
Configuration menu - View commit details
-
Copy full SHA for b0c16f6 - Browse repository at this point
Copy the full SHA b0c16f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3849776 - Browse repository at this point
Copy the full SHA 3849776View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1701729 - Browse repository at this point
Copy the full SHA 1701729View commit details -
Configuration menu - View commit details
-
Copy full SHA for 000e402 - Browse repository at this point
Copy the full SHA 000e402View commit details
Commits on May 27, 2024
-
Add the test for the max retries 0 case.
Configuration menu - View commit details
-
Copy full SHA for 464c142 - Browse repository at this point
Copy the full SHA 464c142View commit details
Commits on May 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b934c44 - Browse repository at this point
Copy the full SHA b934c44View commit details -
Merge branch 'main' of https://github.com/googleapis/nodejs-bigtable …
…into move-retries-createreadstream-get-resumption-logic-working
Configuration menu - View commit details
-
Copy full SHA for af76540 - Browse repository at this point
Copy the full SHA af76540View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5635464 - Browse repository at this point
Copy the full SHA 5635464View commit details -
Configuration menu - View commit details
-
Copy full SHA for 563ee0c - Browse repository at this point
Copy the full SHA 563ee0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for dfaff22 - Browse repository at this point
Copy the full SHA dfaff22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 588e2c8 - Browse repository at this point
Copy the full SHA 588e2c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b9f880 - Browse repository at this point
Copy the full SHA 5b9f880View commit details
Commits on May 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f442b29 - Browse repository at this point
Copy the full SHA f442b29View commit details -
Merge branch 'createreadstream-with-mock-server' of https://github.co…
…m/danieljbruce/nodejs-bigtable into move-retries-createreadstream-get-resumption-logic-working # Conflicts: # system-test/read-rows.ts
Configuration menu - View commit details
-
Copy full SHA for 25eae6d - Browse repository at this point
Copy the full SHA 25eae6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c0085f9 - Browse repository at this point
Copy the full SHA c0085f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc61c28 - Browse repository at this point
Copy the full SHA bc61c28View commit details -
Configuration menu - View commit details
-
Copy full SHA for 726ba7a - Browse repository at this point
Copy the full SHA 726ba7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 403a72f - Browse repository at this point
Copy the full SHA 403a72fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b70192f - Browse repository at this point
Copy the full SHA b70192fView commit details
Commits on May 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 88535e7 - Browse repository at this point
Copy the full SHA 88535e7View commit details
Commits on May 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8b415fa - Browse repository at this point
Copy the full SHA 8b415faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e4b1c1 - Browse repository at this point
Copy the full SHA 5e4b1c1View commit details
Commits on Jun 5, 2024
-
Update test/util/gapic-layer-tester.ts
Co-authored-by: Leah E. Cole <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5880fd7 - Browse repository at this point
Copy the full SHA 5880fd7View commit details -
Update test/util/gapic-layer-tester.ts
Co-authored-by: Leah E. Cole <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3371050 - Browse repository at this point
Copy the full SHA 3371050View commit details -
Update test/util/gapic-layer-tester.ts
Co-authored-by: Leah E. Cole <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fb5b949 - Browse repository at this point
Copy the full SHA fb5b949View commit details -
Update system-test/read-rows.ts
Co-authored-by: Leah E. Cole <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 738b9fd - Browse repository at this point
Copy the full SHA 738b9fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 82ca214 - Browse repository at this point
Copy the full SHA 82ca214View commit details -
Merge branch 'move-retries-createreadstream-get-resumption-logic-work…
…ing' of https://github.com/danieljbruce/nodejs-bigtable into move-retries-createreadstream-get-resumption-logic-working
Configuration menu - View commit details
-
Copy full SHA for c252006 - Browse repository at this point
Copy the full SHA c252006View commit details -
Configuration menu - View commit details
-
Copy full SHA for a6c46c9 - Browse repository at this point
Copy the full SHA a6c46c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd09d69 - Browse repository at this point
Copy the full SHA bd09d69View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac91ca0 - Browse repository at this point
Copy the full SHA ac91ca0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fb2b07 - Browse repository at this point
Copy the full SHA 7fb2b07View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9dd1f7d - Browse repository at this point
Copy the full SHA 9dd1f7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for dda581a - Browse repository at this point
Copy the full SHA dda581aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a05925 - Browse repository at this point
Copy the full SHA 0a05925View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0be0302 - Browse repository at this point
Copy the full SHA 0be0302View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26637b5 - Browse repository at this point
Copy the full SHA 26637b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0491b58 - Browse repository at this point
Copy the full SHA 0491b58View commit details
Commits on Jun 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 10c1a63 - Browse repository at this point
Copy the full SHA 10c1a63View commit details -
Update system-test/read-rows.ts
Co-authored-by: Leah E. Cole <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9831f48 - Browse repository at this point
Copy the full SHA 9831f48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 212f913 - Browse repository at this point
Copy the full SHA 212f913View commit details -
Merge branch 'move-retries-createreadstream-get-resumption-logic-work…
…ing' of https://github.com/danieljbruce/nodejs-bigtable into move-retries-createreadstream-get-resumption-logic-working
Configuration menu - View commit details
-
Copy full SHA for 94df686 - Browse repository at this point
Copy the full SHA 94df686View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac44217 - Browse repository at this point
Copy the full SHA ac44217View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06feb74 - Browse repository at this point
Copy the full SHA 06feb74View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54483fd - Browse repository at this point
Copy the full SHA 54483fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 364738a - Browse repository at this point
Copy the full SHA 364738aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ca3649d - Browse repository at this point
Copy the full SHA ca3649dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9468915 - Browse repository at this point
Copy the full SHA 9468915View commit details
Commits on Jun 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 918d193 - Browse repository at this point
Copy the full SHA 918d193View commit details
Commits on Jun 17, 2024
-
Also update the keys and ranges every time.
Configuration menu - View commit details
-
Copy full SHA for e01b96f - Browse repository at this point
Copy the full SHA e01b96fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 642433c - Browse repository at this point
Copy the full SHA 642433cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 77ce9b6 - Browse repository at this point
Copy the full SHA 77ce9b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 377185b - Browse repository at this point
Copy the full SHA 377185bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d288e8 - Browse repository at this point
Copy the full SHA 4d288e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3df79ce - Browse repository at this point
Copy the full SHA 3df79ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b3196a - Browse repository at this point
Copy the full SHA 3b3196aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 984fc8f - Browse repository at this point
Copy the full SHA 984fc8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f0bdc90 - Browse repository at this point
Copy the full SHA f0bdc90View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17aaae5 - Browse repository at this point
Copy the full SHA 17aaae5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 572b323 - Browse repository at this point
Copy the full SHA 572b323View commit details
Commits on Jun 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 149afaa - Browse repository at this point
Copy the full SHA 149afaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for dd42118 - Browse repository at this point
Copy the full SHA dd42118View commit details -
Configuration menu - View commit details
-
Copy full SHA for 93b7fdb - Browse repository at this point
Copy the full SHA 93b7fdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 79ff3d9 - Browse repository at this point
Copy the full SHA 79ff3d9View commit details
Commits on Jun 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e22af7b - Browse repository at this point
Copy the full SHA e22af7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 66e4b5a - Browse repository at this point
Copy the full SHA 66e4b5aView commit details
Commits on Jun 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1398dca - Browse repository at this point
Copy the full SHA 1398dcaView commit details
Commits on Sep 27, 2024
-
Move retries createreadstream get resumption logic working (googleapi…
…s#1492) * getRanges * Slight refactor of createReadStream * Add header to table utils * Refactor range and keys getting * Pull request opts into a separate function * Revert "Pull request opts into a separate function" This reverts commit c2f4dfe. * logical separation of ranges and keys * Revert "Revert "Pull request opts into a separate function"" This reverts commit 4817863. * set up the test frame * Test is set up to evaluate streaming behavior * Modify test with the mock server to pass first tst * Fix tests that are appending startKey and endKey * Getting all the tests working - Transform the rowsLimit parameter into an integer - Change the hook into a before hook so that we don’t attempt to create multiple mock servers - Create a guard so that the stream only writes if there are row keys to write * eliminate old createreadstream test define new interfaces too * Remove only. rowsLimit should be optional * Make rowKeysRead type more specific * Add after hook to shut down server * Add the less than or equal to fn to utils * remove server start * Add splice ranges back to diagnose problem * Revert "Add splice ranges back to diagnose problem" This reverts commit 5edaf82. * get all tests passing readRowsReqOpts should have an ECMAscript prefix to completely hide it from the user. Also remove a useless Filter.parse. * Use tableUtils lessthanorequalto * refactor: Move retries finish making createreadstream smaller * More specific type for options * Import type and replace with any * Turn on gax streaming retries * Try out the shouldRetryFn * Service error or Google error for this function Also uncommented retry logic to see how the test would behave. * First PR correction - remove any * Get rid of another any * Get rid of the any suppressed by typescript It was necessary to add guards to make this work. Also changed the error type to Google error. * Should use CreateReadStreamRequest as the type * Remove the comment disabling linting on any * Remove the import. It is not used anymore. * Remove the custom retry logic * Wrote a test that mocks gapic that will compile * Refactor the test so that it is easy to Move the check out into a separate function. * Add expected values for request * Do not append retryRequestOptions to gax options Appending retryRequestOptions will not work for any call that is also passing in the retry gax parameter. * Factor out the retry options logic Move functions out of table.ts that other methods should not be concerned with. Export the function that creates retry logic from this new module * Rename the file to retry-options This is going to be used by the mutate row retry options so the filename should not be so specific. * Initial attempt at adding resumption logic * skip * Comment out check in test * Keep the resumption strategy in table.ts for now There is currently a proxyquire issue preventing us from moving code out of table.ts so make a TODO and move it later. * Get proxyquire logic right Move the resumption strategy back to its own file and get the proxyquire configs right so that tests pass. * Remove unused code * Wrap with arrow functions. We can’t pass class methods in * Use the resumption request * Set up a unit test framework This ensures the right parameters are passed along to the gapic layer. * Make sure to pass along maxRetries to the gapic * Do an empty write to ensure server called only one * Gets all 10 tests passing Some issue with the mock server is making it so that responses don’t get sent back the way they should. This change allows all the tests to pass. * Pull testing code out into a dedicated object * Mock out project id properly. * Delete code * maxRetries test rename * Pass in the filter * Remove unused parameter * Create tableStrategyInfo case class * Fix appProfileId issue * Basic resumption test added * More resumption tests * Get resumption logic tests into its own module * Modify test name with reumption strategy * Skip a test * Remove a function that isn’t used anymore * inline building request options * Remove unused imports * Remove imports that are not used * Inline some functions to eliminate confusion * Move comment to where it was before * Better test parameterization * Replace grpc error codes with programmatic result * Correct interface * Uncomment some code removed from before * Remove this TODO * Move tests to unit test folder. * Better comments * Update comment * better spacing * correct grammar * Change to retry options construction * Add a test for passing custom retry options * Fix the complex example passing options along * Pull functions out of TableUtils These functions do not need to exist as a static method. Put them in the readrows resumption module. * Import bug fix * Moved some tests over Moved some unit tests over to the system test json file. * Check to see if maxRetries is undefined * Change retry options - wrap in gaxOpts * Move over should remove ranges which were already read * move more tests over should not retry if limit is reached should remove the keys which were already read 'should remove ranges which were already read * Add limit test and retry if all keys are read test * Move should not retry if all the ranges are read * Expected error code is 4 * Move location of updates * Correct tests with new info * Correct the json test file * Modify test to match old test * Moved rststream test over * Add framework to mock server so that error message * Remove the RST stream test * Delete retries test block * Make sure to call canResume in all cases * chore: update copyright year for auto-generated protos (googleapis#1417) * chore: update copyright year for auto-generated protos PiperOrigin-RevId: 631538781 Source-Link: googleapis/googleapis@3597f7d Source-Link: googleapis/googleapis-gen@8021fdf Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODAyMWZkZjhkNjZmNjAwNTUxOWMwNDRkNTgzNDEyNGI2NzdkYzkxOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * Remove retryOpts from mutate function * indent so diff is easier to read * Expand on comment * Fix side effects from turning on streaming retries * Simplify the diff * Add comments for a better description * Remove any and replace with more specific type * Correct test types to CreateReadStreamRequest * Coerce types and reintroduce parseInt to match expectations * Remove unused import * feat: Add feature for copying backups (googleapis#1153) * src test and protos copied over * lint fix * implemented copy backup * part of test done * workaround * corrections to get code working * Add expire time * This allows the copy backup endpoint to work * Working system test * delete try block * tests pass with new refactor * Create backup and copy on another cluster * modifications to second test * copy backup unit test * Revert "lint fix" This reverts commit 576550d. * Revert "src test and protos copied over" This reverts commit 46ce5b8. * First correction * Check the list of backups * fetched backup * get name and id * Remove only * refactor request mock * Add unit test for copying backup to another projec * feat: add experimental reverse scan for public preview PiperOrigin-RevId: 543539118 Source-Link: googleapis/googleapis@ae18706 Source-Link: googleapis/googleapis-gen@5d05516 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNWQwNTUxNmY4NGU1M2FhYmE2M2E0Yjg3NjdmZjk1NWFjNWJiNGE4NyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: Increase the maximum retention period for a Cloud Bigtable backup from 30 days to 90 days PiperOrigin-RevId: 544356969 Source-Link: googleapis/googleapis@c35889a Source-Link: googleapis/googleapis-gen@c00326e Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzAwMzI2ZWM3ODU2NWI1ZDE2ZjkyYzg0NWZmMGJiMThmMTFjYTA1ZCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * docs: fix formatting for reversed order field example PiperOrigin-RevId: 547553954 Source-Link: googleapis/googleapis@c4e6427 Source-Link: googleapis/googleapis-gen@f552269 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjU1MjI2OTYwOWQ0MTgzNTQ2NTQzYmZlM2EwMjJmNTQ0ZDRmNWJkYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: add last_scanned_row_key feature PiperOrigin-RevId: 551191182 Source-Link: googleapis/googleapis@51e04ba Source-Link: googleapis/googleapis-gen@4b90e8e Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGI5MGU4ZWFkNDQ3N2VmZjk2YzMxYjliMGZkZWYzNmVkOTc1YjE1ZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: fix typings for IAM methods docs: fixed links in the generated Markdown documentation PiperOrigin-RevId: 551610576 Source-Link: googleapis/googleapis@73b1313 Source-Link: googleapis/googleapis-gen@8bec066 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGJlYzA2NjQ5MmE2ZGEyODU1YjFiOGNlNTYyNjY0YzBhNmIzMGIwMSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * test: disable retry-request for streaming tests PiperOrigin-RevId: 554648220 Source-Link: googleapis/googleapis@53cd9ad Source-Link: googleapis/googleapis-gen@7e8867e Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2U4ODY3ZWZiZWQ3ZGJmZTVlZjZlYzNjMmM5MmE0YmNlNDI4MGY3YSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: publish CopyBackup protos to external customers PiperOrigin-RevId: 557192020 Source-Link: googleapis/googleapis@b4c238f Source-Link: googleapis/googleapis-gen@feccb30 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZmVjY2IzMGUzMTc3ZGE4YjdiN2U2ODE0OWNhNGJiOTE0ZjhmYWYyYSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: simplify logic for HTTP/1.1 REST fallback option For the `fallback` parameter, all values considered as `true` in Boolean context will enable HTTP/1.1 REST fallback, since the other fallback transport, proto over HTTP, is removed from `google-gax` v4. PiperOrigin-RevId: 559812260 Source-Link: googleapis/googleapis@6a6fd29 Source-Link: googleapis/googleapis-gen@56c1665 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTZjMTY2NTdlN2E1OTEyMmIxZGE5NDc3MWE5ZWY0MDk4OWMyODJjMCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: add feature flag for improved mutate rows throttling PiperOrigin-RevId: 565090488 Source-Link: googleapis/googleapis@e8a136f Source-Link: googleapis/googleapis-gen@9a8dcca Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOWE4ZGNjYTBmYjIxMTc2MjhhMWE2YTZjMzYyNWE2YWEzMmZjMmY3NSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * run lint * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * build: update typescript generator version to publish in dual format (ESM) PiperOrigin-RevId: 568643156 Source-Link: googleapis/googleapis@f95afc0 Source-Link: googleapis/googleapis-gen@bbd2c49 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYmJkMmM0OWQyZTQyM2E4Y2U1Y2M4NTYyNzQwMmQ1MTJhZWVmYzU4YiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: Add support for Cloud Bigtable Request Priorities in App Profiles PiperOrigin-RevId: 571158646 Source-Link: googleapis/googleapis@bc3c83b Source-Link: googleapis/googleapis-gen@93366e8 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTMzNjZlODRlNGU2ODYxZTJlNTgwZWIwMDA3MjFkOTliZjU0YTBhNCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * build: update Node.js generator to compile protos PiperOrigin-RevId: 582493526 Source-Link: googleapis/googleapis@7c4e4b5 Source-Link: googleapis/googleapis-gen@368cfb6 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzY4Y2ZiNjUxMDE2ZDZhOTNjYTZlNDg4Y2JjMzRlMmQxZDlkMjEyYyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Use the destination backup expiry time Expiry time of the destination should be used for the call. Not for the source expiry time. * Use the config instead for copy backup Use the config and not the backup object for copying backups. The expiry time is needed so a backup object can’t be used because the metadata cannot be introspected. * Rename CopyBackupConfig Rename it to DestinationBackupConfig. * Fix signature of copyBackup Fix the signature of copyBackup to include the fact that the config now has the gax options. * Change the copy signature to require callback If the callback is not required then all calls match first signature overload and async calls return void which isn’t correct. * Some debugging on the system tests The system tests were giving an error about the source expiry time and now this is fixed. * DestinationBackupConfig Don’t use the name DestinationBackupConfig anymore. * lint fix * Move the config and create a generic callback Create a generic callback data structure in order to avoid callback and promise data structures not matching up. Also move the configs to a different file. * Eliminate the generic callback data structure Eliminate the generic data structure as it can’t be used to capture the pattern we need exactly. Also modify the way that errors are passed into the callback function to be more consistent. * Get the first copy backup test working Copy the backup into the same cluster test is working. Still need to work on copy backup for test that looks at a different cluster to get that test working. * Fix different cluster, different instance test Fix the issue preventing the second test from working by allowing the test function to specify the instance where the new backups should be created. * Add another test for copy backup The test should address a backup copied to a different cluster, but the same instance. * Add a test case for copying to another project Test case for copying to another project uses environment variable to point to new project for CI pipeline. * Restructure tests for multiple expire time inputs Take one of the tests and structure it into a describe block instead. Each test in this block will now run the old test with a different expiry time format. * Various changes to test interaction with copy back Rename backupId to id. id is a simpler name and it is the name that is used everywhere. Rename a function to testWithExpiryTimes. Modify source code for copy function to return a backup with the new id. Add test stub for restore backup. * Finish the restore tests and modify copy backup The restore test should test to see if a table can be restored. It should also return a backup object that matches the new backup created. * Add comment describing second argument Second argument is a backup that corresponds to a new backup. This needs to be explained in a comment. * Remove TODO The TODO is done * Modify copy backup unit test Modify the copy backup unit test to compare against copying the a destination with customized cluster, backup, instance and project. * Modify the name of the test The test is not necessarily about copying to a different project. It is more a test about copying to a specific project. * Test for gax options in the test Make sure that the gax options get passed down to the request layer. * TODO is done The promise and callbacks follow the same pattern that is applied everywhere. * Change comment slightly It is actually more of a check than an action that ensures something. * Eliminate TODO The id is required. It can’t be generated automatically by the server. It needs to be provided. * Fix documentation for source function Add description for the parameters and explain what the function does. * Move copy backup code to proper place The tests were originally placed in a block at the very beginning so that they were easier to work through. This change moves them to the proper place. * Use cluster instead of parent cluster should be used instead of parent to specify the destination cluster. * Change parent to cluster cluster name should be used instead of parent to match the design doc. * A couple cleanup changes Id is required so no question mark needed. Also inline the function that replaces the project name. * Use parent instead of cluster This test was accidentally changed by a refactor and should not change further. * Eliminate unused time references Variables were created so that time can be used in a block of tests. That block of tests were moved so these. variables are no longer needed. * This test should not have changed Use parent instead of cluster because that is what it was before. * Eliminate unused import CreateBackupConfig is not used anywhere. * Remove assert statement that is not needed * Move two lines of code to location used General cleanup for readability * Improve readability Reduce number of lines required in testWithExpiryTimes function. This makes the function easier to read. * Inline variables instead of using them explicitly Don’t use the variables explicitly. Inline them instead. * Generate the backup id inline An extra variable is not needed for this. * readability - indent code so it is separate Also inline the id generation as it is not used elsewhere. * Indent block to separate check Separate expiry time check from the rest of the code. * indent cluster creation, expiry time check Indenting the code makes it easier to see variable relationships * Another test cleanup Inline Bigtable instance creation options. Indent code for checking expiry time. * Add comment Comment is for test that copies a table onto another project. * Indent code for table data insertion Indenting this code shows it is not referenced later. * Rename variables to distinguish operations Differentiate copy operation from create operation. * Eliminate unused imports * should be lower case * Change comment to respect alignment * Inline callback, config and cluster Inline variables for better readability * Remove unused operation * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Delete an instance Delete the instance after it is used just like the other test. * Inline generate id A generateId function I need to inline. * Add second project to config Import the second project to use in the integration tests * Rename the function to setBackupExpiryTime Rename this function to be more specific. * Replace the project for backup path Currently this test is too specific. It does not work if a specific project is specified in the client so we must only check the rest of the backup path. * Run the linter Linter removes unnecessary comma. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update comments for the copy function This function needs to be more clear and explain exactly what it does without ambiguity. * Rename function that sets correct value of expiry expiryTime should be in the right format so rename function to more clearly indicate what it is doing. * Add an environment variable for second project The variable for the second project is needed for the the integration tests to run properly for the copy backup test that copies to another project. * Add log for second project See what kokoro prints out. * Remove the console log This was just for testing. Remove this now. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Rename bigtable to bigtableSecondaryProject * PR follow-ups - inline code and rename variables * Remove unused import * Add comments for expire time * Add better garbage cleanups of the backups * These comments are not needed anymore. * Remove only * Update system-test/bigtable.ts Co-authored-by: Leah E. Cole <[email protected]> * Update system-test/bigtable.ts Co-authored-by: Leah E. Cole <[email protected]> --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: sofisl <[email protected]> Co-authored-by: Sofia Leon <[email protected]> Co-authored-by: meredithslota <[email protected]> Co-authored-by: Leah E. Cole <[email protected]> * Rename the comment as a TODO * Complete comment * Add latency measurements to mock server tests This commit contains a tool useful for printing latency results. * Revert "Add latency measurements to mock server tests" This reverts commit d3d05a2. * Revert "Complete comment" This reverts commit 32fe3e5. * Revert "Rename the comment as a TODO" This reverts commit 80cf68c. * Resolve the spacing issues * Solve remaining spacing issues * Add spaces back * Add the new test back in Add the test for the max retries 0 case. * feat: Add String type with Utf8Raw encoding to Bigtable API (googleapis#1419) * feat: update Nodejs generator to send API versions in headers for GAPICs PiperOrigin-RevId: 634109303 Source-Link: googleapis/googleapis@998ade8 Source-Link: googleapis/googleapis-gen@000ca6f Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDAwY2E2ZjAwODAxZjY1Yjg0N2U2MDI5Y2IwNTExMTQwNGRmMjFlYyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: Add String type with Utf8Raw encoding to Bigtable API Bigtable will allow users to configure the type of a column family with string type PiperOrigin-RevId: 636631633 Source-Link: googleapis/googleapis@89a8364 Source-Link: googleapis/googleapis-gen@d776700 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDc3NjcwMDdlYWUwZmU4Nzc1NWIyMWNmZTU2OWI4Nzc5ZjAyMTUxYyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: danieljbruce <[email protected]> * Change the Gapic layer back to what it was * Fix max retries test * Remove only * Add header * Add comments to the tester * Add comments for the test functions. * Remove the TODOs * Fix lint warning * Address another lint warning * Remove Filter * Add stronger type checking to userStream.end fn * Create a better overloaded version of userStreamen * Remove reference to proto * Added a comment about streaming retries set to tru * Add comments to determine what table.ts should do * chore(main): release 5.1.0 (googleapis#1321) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * Update test/util/gapic-layer-tester.ts Co-authored-by: Leah E. Cole <[email protected]> * Update test/util/gapic-layer-tester.ts Co-authored-by: Leah E. Cole <[email protected]> * Update test/util/gapic-layer-tester.ts Co-authored-by: Leah E. Cole <[email protected]> * Update system-test/read-rows.ts Co-authored-by: Leah E. Cole <[email protected]> * For max retries have a default retry count * Define a retry count constant * Update the comment * Move check for rst error. Rename MockGapicLayer. * linter * Make test case description more specific * Rename the file * RST stream error message inclusion * Don’t retry on resource exhausted * Remove service error from imports * RetryInfo in the status details should retry * Remove unnecessary code for compilation * Update system-test/read-rows.ts Co-authored-by: Leah E. Cole <[email protected]> * Remove the arrow function * Remove comments and replace with constants * Update the comment for getRowKeys * Move variables inside the if statement * Add a test case for row ranges and row keys * Add a test case that doesn’t do any filtering * Remove TODO * remove type any * Allow user to override codes Also update the keys and ranges every time. * Add another test for overriding the retry codes * Make the test a little bit more robust * Update the test framework to measure shouldRetry * Add another test ensuring a retry doesn’t happen * rename the test * Make canResume always run unless shouldRetryFn pr * Gapic layer should expect empty retry codes * Remove copied file * Change the resumption strategy * Replace 13 with enum * Removed example * npm run fix * Revert "npm run fix" This reverts commit dd42118. * Remove overrides * Remove irrelevant test * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Daniel Bruce <[email protected]> Co-authored-by: gcf-owl-bot[bot] <78513119+gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: danieljbruce <[email protected]> Co-authored-by: sofisl <[email protected]> Co-authored-by: Sofia Leon <[email protected]> Co-authored-by: meredithslota <[email protected]> Co-authored-by: Leah E. Cole <[email protected]> Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for b43468e - Browse repository at this point
Copy the full SHA b43468eView commit details -
Merge branch 'googleapis:move-retries-createreadstream-get-resumption…
…-logic-working' into move-retries-createreadstream-get-resumption-logic-working
Configuration menu - View commit details
-
Copy full SHA for eb3ead5 - Browse repository at this point
Copy the full SHA eb3ead5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c4910c - Browse repository at this point
Copy the full SHA 0c4910cView commit details
Commits on Sep 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 77f0e11 - Browse repository at this point
Copy the full SHA 77f0e11View commit details
Commits on Oct 1, 2024
-
Co-authored-by: Leah E. Cole <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7e319bd - Browse repository at this point
Copy the full SHA 7e319bdView commit details