Added example region-tag for Family.js #262

vijay-qlogic · 2018-08-01T09:23:20Z

Fixes #157 for family.js (it's a good idea to open an issue first for discussion)

Tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

codecov · 2018-08-01T09:26:49Z

Codecov Report

❗ No coverage uploaded for pull request base (master@3886233). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             master   #262   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?     10           
  Lines             ?   1281           
  Branches          ?      0           
=======================================
  Hits              ?   1281           
  Misses            ?      0           
  Partials          ?      0

Impacted Files	Coverage Δ
src/family.js	`100% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3886233...8eeff5c. Read the comment docs.

samples/document-snippets/tests/family.js

+  });
+
+  it('should create a column family', function(done) {
+    familySnippets.createColmFamily(INSTANCE_ID, TABLE_ID, FAMILY_ID, err => {


samples/document-snippets/family.js

+      .then(result => {
+        const family = result[0];
+        // let apiResponse = result[1];
+        callback(null, family);


samples/document-snippets/family.js

+        // const apiResponse = result[1];
+      })
+      .catch(err => {
+        // handle error


samples/document-snippets/family.js

+    // [END bigtable_get_family_meta]
+    callback();
+  },
+  setMetaData: (instanceId, tableId, familyId, callback) => {


samples/document-snippets/family.js

+    // [END bigtable_get_family]
+    callback();
+  },
+  getMetaData: (instanceId, tableId, familyId, callback) => {


samples/document-snippets/family.js

+    const table = instance.table(tableId);
+    const family = table.family(familyId);
+    // [START bigtable_set_family_meta]
+    var metadata = {


samples/document-snippets/tests/family.js

@@ -0,0 +1,75 @@
+/**
+ * Copyright 2016 Google Inc. All Rights Reserved.


samples/document-snippets/tests/family.js

+    familySnippets.getFamily(INSTANCE_ID, TABLE_ID, FAMILY_ID, done);
+  });
+
+  it('should get family meta-data', function(done) {


samples/document-snippets/tests/family.js

+    familySnippets.getMetaData(INSTANCE_ID, TABLE_ID, FAMILY_ID, done);
+  });
+
+  it('should set family meta-data', function(done) {


sduskis

Overall, looks good. Let's keep the documentation consistent, and include the @require in the docs, even though we didn't have that before.

samples/document-snippets/family.js

+    const instance = bigtable.instance(instanceId);
+    const table = instance.table(tableId);
+    const family = table.family(familyId);
+    // [START bigtable_create_family]


samples/document-snippets/family.js

+    const table = instance.table(tableId);
+    const family = table.family(familyId);
+
+    // [START bigtable_exists_family]


sduskis · 2018-11-02T14:11:53Z

@vijay-qlogic, can you please address the comments?

sduskis · 2018-11-09T17:06:47Z

@stephenplusplus, can we move forward with this PR?

Obsolete

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 1, 2018

vijay-qlogic force-pushed the tag-ex-comments-family branch from ad72fc3 to fd4f38f Compare August 1, 2018 09:27

stephenplusplus reviewed Aug 1, 2018

View reviewed changes

samples/document-snippets/tests/family.js Outdated

});

it('should create a column family', function(done) {

familySnippets.createColmFamily(INSTANCE_ID, TABLE_ID, FAMILY_ID, err => {

This comment was marked as spam.

Sign in to view

stephenplusplus reviewed Aug 1, 2018

View reviewed changes

samples/document-snippets/family.js Outdated

.then(result => {

const family = result[0];

// let apiResponse = result[1];

callback(null, family);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

vijay-qlogic force-pushed the tag-ex-comments-family branch 3 times, most recently from 26384d3 to ba03406 Compare August 9, 2018 06:21

ghost assigned sduskis Aug 10, 2018

vijay-qlogic force-pushed the tag-ex-comments-family branch from 9c89117 to 1a8fbaf Compare August 13, 2018 17:00

stephenplusplus previously requested changes Aug 15, 2018

View reviewed changes

vijay-qlogic force-pushed the tag-ex-comments-family branch 2 times, most recently from f916a56 to 07ba77d Compare August 20, 2018 17:31

vijay-qlogic force-pushed the tag-ex-comments-family branch 3 times, most recently from 01edd6f to 3763d72 Compare August 31, 2018 17:33

vijay-qlogic force-pushed the tag-ex-comments-family branch from 3763d72 to 308d9ff Compare September 5, 2018 17:59

vijay-qlogic added 6 commits October 5, 2018 17:18

Added example region-tag for Family.js

76980c8

callback removed from promise-style code-snippets within region-tags

8418583

minor fix

27dadab

sample ID updated

6b045e7

Added review updates

4a96e3d

removed callbacks

7a94e77

vijay-qlogic force-pushed the tag-ex-comments-family branch from 1b1e028 to 7a94e77 Compare October 5, 2018 11:50

vijay-qlogic and others added 2 commits October 5, 2018 17:26

rebased with master and code-review update

237319d

Merge branch 'master' into tag-ex-comments-family

08b48c9

sduskis suggested changes Oct 5, 2018

View reviewed changes

vijay-qlogic and others added 3 commits October 5, 2018 21:15

code review updates

cf43015

Merge branch 'master' into tag-ex-comments-family

4c5c185

Merge branch 'master' into tag-ex-comments-family

58c87fc

sduskis mentioned this pull request Oct 12, 2018

Bigtable: Many APIs have outdated exmples googleapis/google-cloud-java#3815

Closed

sduskis approved these changes Oct 23, 2018

View reviewed changes

sduskis added 3 commits October 23, 2018 13:52

Merge branch 'master' into tag-ex-comments-family

7aeefc4

Merge branch 'master' into tag-ex-comments-family

b03f296

Merge branch 'master' into tag-ex-comments-family

e96e20c

Merge branch 'master' into tag-ex-comments-family

8eeff5c

sduskis approved these changes Nov 9, 2018

View reviewed changes

Merge branch 'master' into tag-ex-comments-family

f806c27

sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2018

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2018

sduskis merged commit 41d6d68 into googleapis:master Nov 12, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added example region-tag for Family.js #262

Added example region-tag for Family.js #262

vijay-qlogic commented Aug 1, 2018

codecov bot commented Aug 1, 2018 •

edited

Loading

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

sduskis left a comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

sduskis commented Nov 2, 2018

sduskis commented Nov 9, 2018

		@@ -0,0 +1,75 @@
		/**
		* Copyright 2016 Google Inc. All Rights Reserved.

Added example region-tag for Family.js #262

Added example region-tag for Family.js #262

Conversation

vijay-qlogic commented Aug 1, 2018

codecov bot commented Aug 1, 2018 • edited Loading

Codecov Report

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

sduskis left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

sduskis commented Nov 2, 2018

sduskis commented Nov 9, 2018

codecov bot commented Aug 1, 2018 •

edited

Loading