Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): make Filter class public so it shows up in docs #331

Merged
merged 1 commit into from
Oct 20, 2018
Merged

fix(docs): make Filter class public so it shows up in docs #331

merged 1 commit into from
Oct 20, 2018

Conversation

jkwlui
Copy link
Member

@jkwlui jkwlui commented Oct 19, 2018

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 19, 2018
@ghost ghost assigned jkwlui Oct 19, 2018
@jkwlui jkwlui changed the title fix(docs): make Filter class public should it shows up in docs fix(docs): make Filter class public so it shows up in docs Oct 19, 2018
@jkwlui jkwlui requested a review from sduskis October 19, 2018 23:42
@jkwlui jkwlui added the semver: patch A minor bug fix or small change. label Oct 19, 2018
@codecov
Copy link

codecov bot commented Oct 20, 2018 •
edited
Loading

Codecov Report

Merging #331 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #331   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10     10           
  Lines        1287   1287           
=====================================
  Hits         1287   1287
Impacted Files Coverage Δ
src/filter.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63c90dc...dace64a. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit 13efc4d into master Oct 20, 2018
@sduskis sduskis deleted the make-Filter-public branch November 13, 2018 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@sduskis sduskis Awaiting requested review from sduskis

Assignees

@jkwlui jkwlui

Labels
cla: yes This human has signed the Contributor License Agreement. semver: patch A minor bug fix or small change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkwlui @JustinBeckwith @googlebot